Skip to content

Upgrade to GHC 9.2.2 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhess opened this issue Oct 31, 2021 · 5 comments
Closed

Upgrade to GHC 9.2.2 #189

dhess opened this issue Oct 31, 2021 · 5 comments
Assignees
@dhess
Labels
blocked/upstream ❌ Blocked by upstream issue Haskell Haskell-related long-term goal A long-term goal, but not attached to a particular milestone yet tracking This is a tracking issue upstream This is an upstream issue

Comments

@dhess
Copy link
Member

dhess commented Oct 31, 2021 •
edited
Loading

Edit: GHC 9.2.2 has been released. Now we're just waiting for the libraries to catch up.

Edit: Oops, make that GHC 9.2.2. Turns out 9.2.1 is broken on aarch64: https://discourse.haskell.org/t/psa-9-2-1-aarch64-miscompilation/3638

Once all the pieces are in place, I think we should upgrade to GHC 9.2.2 and not look back, taking full advantage of its features, like the new record syntax and the GHC2021 extension set. I'm not particularly concerned about compatibility with older versions, especially as we don't have any third party users of the Primer Haskell packages yet.

We'll need the following before we can make the switch:

  • haskell.nix support, 'natch.
  • We can use GHC 9.2.2 to build primer, primer-selda, and primer-service, and pass all tests, on the following platforms: x86_64-linux, aarch64-linux, x86_64-darwin, aarch64-darwin. (I will add support for both types of aarch64 builds to our Hydra & remote builders soon.)
  • HLS support.

Eventually we'll also need a GHCJS 9.2.x that can build primer, but so long as we're certain that work is progressing on that & upstream has a plan, I'm comfortable making the switch without waiting for that piece. Realistically, running primer in the frontend is a long way off, so there's no point waiting around for GHCJS 9.2.x.

Let me know if I've missed anything.
@dhess dhess added Haskell Haskell-related upstream This is an upstream issue tracking This is a tracking issue long-term goal A long-term goal, but not attached to a particular milestone yet blocked/upstream ❌ Blocked by upstream issue Hydra labels Oct 31, 2021
@dhess dhess self-assigned this Oct 31, 2021
@dhess dhess changed the title Upgrade to GHC 9.2.1 Upgrade to GHC 9.2.2 Nov 11, 2021
@dhess
Copy link
Member Author

dhess commented Nov 14, 2021 •
edited
Loading

See #197 Failed miserably. There are a lot of dependencies not ready for GHC 9.x yet.

@georgefst
Copy link
Contributor

  • HLS support.

Version 1.6 adds mostly-complete support for GHC 9.2. And 9.2.2 is likely to be supported almost as soon as it's released, since minor versions don't alter the GHC API.

@georgefst georgefst mentioned this issue Mar 3, 2022
Closed
@brprice
Copy link
Contributor

brprice commented Mar 3, 2022

there's no point waiting around for GHCJS 9.2.x.

Just FYI: there's some noises being made about merging GHCJS into GHC proper, though I have no idea on a timeline here https://gitlab.haskell.org/ghc/ghc/-/issues/21078

@dhess
Copy link
Member Author

dhess commented Mar 3, 2022

Looks like they're targeting GHC 9.6 at the time of writing: https://gitlab.haskell.org/ghc/ghc/-/wikis/javascript-backend#which-timeframe

@dhess
Copy link
Member Author

dhess commented Jun 2, 2022

This was (finally) fixed in #244.

@dhess dhess closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhess dhess

Labels
blocked/upstream ❌ Blocked by upstream issue Haskell Haskell-related long-term goal A long-term goal, but not attached to a particular milestone yet tracking This is a tracking issue upstream This is an upstream issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhess @brprice @georgefst