Skip to content

Commit adf53a7

Browse files
Roberto SassuMimi Zohar
Roberto Sassu
authored and
Mimi Zohar
committed
ima: new templates management mechanism
The original 'ima' template is fixed length, containing the filedata hash and pathname. The filedata hash is limited to 20 bytes (md5/sha1). The pathname is a null terminated string, limited to 255 characters. To overcome these limitations and to add additional file metadata, it is necessary to extend the current version of IMA by defining additional templates. The main reason to introduce this feature is that, each time a new template is defined, the functions that generate and display the measurement list would include the code for handling a new format and, thus, would significantly grow over time. This patch set solves this problem by separating the template management from the remaining IMA code. The core of this solution is the definition of two new data structures: a template descriptor, to determine which information should be included in the measurement list, and a template field, to generate and display data of a given type. To define a new template field, developers define the field identifier and implement two functions, init() and show(), respectively to generate and display measurement entries. Initially, this patch set defines the following template fields (support for additional data types will be added later):  - 'd': the digest of the event (i.e. the digest of a measured file),         calculated with the SHA1 or MD5 hash algorithm;  - 'n': the name of the event (i.e. the file name), with size up to         255 bytes;  - 'd-ng': the digest of the event, calculated with an arbitrary hash            algorithm (field format: [<hash algo>:]digest, where the digest            prefix is shown only if the hash algorithm is not SHA1 or MD5);  - 'n-ng': the name of the event, without size limitations. Defining a new template descriptor requires specifying the template format, a string of field identifiers separated by the '|' character. This patch set defines the following template descriptors:  - "ima": its format is 'd|n';  - "ima-ng" (default): its format is 'd-ng|n-ng' Further details about the new template architecture can be found in Documentation/security/IMA-templates.txt. Changelog: - don't defer calling ima_init_template() - Mimi - don't define ima_lookup_template_desc() until used - Mimi - squashed with documentation patch - Mimi Signed-off-by: Roberto Sassu <[email protected]> Signed-off-by: Mimi Zohar <[email protected]>
1 parent 7bc5f44 commit adf53a7

File tree

6 files changed

+235
-1
lines changed

6 files changed

+235
-1
lines changed

Documentation/security/00-INDEX

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,5 @@ keys.txt
2222
- description of the kernel key retention service.
2323
tomoyo.txt
2424
- documentation on the TOMOYO Linux Security Module.
25+
IMA-templates.txt
26+
- documentation on the template management mechanism for IMA.
Lines changed: 87 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,87 @@
1+
IMA Template Management Mechanism
2+
3+
4+
==== INTRODUCTION ====
5+
6+
The original 'ima' template is fixed length, containing the filedata hash
7+
and pathname. The filedata hash is limited to 20 bytes (md5/sha1).
8+
The pathname is a null terminated string, limited to 255 characters.
9+
To overcome these limitations and to add additional file metadata, it is
10+
necessary to extend the current version of IMA by defining additional
11+
templates. For example, information that could be possibly reported are
12+
the inode UID/GID or the LSM labels either of the inode and of the process
13+
that is accessing it.
14+
15+
However, the main problem to introduce this feature is that, each time
16+
a new template is defined, the functions that generate and display
17+
the measurements list would include the code for handling a new format
18+
and, thus, would significantly grow over the time.
19+
20+
The proposed solution solves this problem by separating the template
21+
management from the remaining IMA code. The core of this solution is the
22+
definition of two new data structures: a template descriptor, to determine
23+
which information should be included in the measurement list; a template
24+
field, to generate and display data of a given type.
25+
26+
Managing templates with these structures is very simple. To support
27+
a new data type, developers define the field identifier and implement
28+
two functions, init() and show(), respectively to generate and display
29+
measurement entries. Defining a new template descriptor requires
30+
specifying the template format, a string of field identifiers separated
31+
by the '|' character. While in the current implementation it is possible
32+
to define new template descriptors only by adding their definition in the
33+
template specific code (ima_template.c), in a future version it will be
34+
possible to register a new template on a running kernel by supplying to IMA
35+
the desired format string. In this version, IMA initializes at boot time
36+
all defined template descriptors by translating the format into an array
37+
of template fields structures taken from the set of the supported ones.
38+
39+
After the initialization step, IMA will call ima_alloc_init_template()
40+
(new function defined within the patches for the new template management
41+
mechanism) to generate a new measurement entry by using the template
42+
descriptor chosen through the kernel configuration or through the newly
43+
introduced 'ima_template=' kernel command line parameter. It is during this
44+
phase that the advantages of the new architecture are clearly shown:
45+
the latter function will not contain specific code to handle a given template
46+
but, instead, it simply calls the init() method of the template fields
47+
associated to the chosen template descriptor and store the result (pointer
48+
to allocated data and data length) in the measurement entry structure.
49+
50+
The same mechanism is employed to display measurements entries.
51+
The functions ima[_ascii]_measurements_show() retrieve, for each entry,
52+
the template descriptor used to produce that entry and call the show()
53+
method for each item of the array of template fields structures.
54+
55+
56+
57+
==== SUPPORTED TEMPLATE FIELDS AND DESCRIPTORS ====
58+
59+
In the following, there is the list of supported template fields
60+
('<identifier>': description), that can be used to define new template
61+
descriptors by adding their identifier to the format string
62+
(support for more data types will be added later):
63+
64+
- 'd': the digest of the event (i.e. the digest of a measured file),
65+
calculated with the SHA1 or MD5 hash algorithm;
66+
- 'n': the name of the event (i.e. the file name), with size up to 255 bytes;
67+
- 'd-ng': the digest of the event, calculated with an arbitrary hash
68+
algorithm (field format: [<hash algo>:]digest, where the digest
69+
prefix is shown only if the hash algorithm is not SHA1 or MD5);
70+
- 'n-ng': the name of the event, without size limitations.
71+
72+
73+
Below, there is the list of defined template descriptors:
74+
- "ima": its format is 'd|n';
75+
- "ima-ng" (default): its format is 'd-ng|n-ng'.
76+
77+
78+
79+
==== USE ====
80+
81+
To specify the template descriptor to be used to generate measurement entries,
82+
currently the following methods are supported:
83+
84+
- select a template descriptor among those supported in the kernel
85+
configuration ('ima-ng' is the default choice);
86+
- specify a template descriptor name from the kernel command line through
87+
the 'ima_template=' parameter.

security/integrity/ima/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@
66
obj-$(CONFIG_IMA) += ima.o
77

88
ima-y := ima_fs.o ima_queue.o ima_init.o ima_main.o ima_crypto.o ima_api.o \
9-
ima_policy.o
9+
ima_policy.o ima_template.o
1010
ima-$(CONFIG_IMA_APPRAISE) += ima_appraise.o

security/integrity/ima/ima.h

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,39 @@ enum tpm_pcrs { TPM_PCR0 = 0, TPM_PCR8 = 8 };
3636
#define IMA_HASH_BITS 9
3737
#define IMA_MEASURE_HTABLE_SIZE (1 << IMA_HASH_BITS)
3838

39+
#define IMA_TEMPLATE_FIELD_ID_MAX_LEN 16
40+
#define IMA_TEMPLATE_NUM_FIELDS_MAX 15
41+
3942
/* set during initialization */
4043
extern int ima_initialized;
4144
extern int ima_used_chip;
4245
extern int ima_hash_algo;
4346
extern int ima_appraise;
4447

48+
/* IMA template field data definition */
49+
struct ima_field_data {
50+
u8 *data;
51+
u32 len;
52+
};
53+
54+
/* IMA template field definition */
55+
struct ima_template_field {
56+
const char field_id[IMA_TEMPLATE_FIELD_ID_MAX_LEN];
57+
int (*field_init) (struct integrity_iint_cache *iint, struct file *file,
58+
const unsigned char *filename,
59+
struct ima_field_data *field_data);
60+
void (*field_show) (struct seq_file *m, enum ima_show_type show,
61+
struct ima_field_data *field_data);
62+
};
63+
64+
/* IMA template descriptor definition */
65+
struct ima_template_desc {
66+
char *name;
67+
char *fmt;
68+
int num_fields;
69+
struct ima_template_field **fields;
70+
};
71+
4572
/* IMA inode template definition */
4673
struct ima_template_data {
4774
u8 digest[IMA_DIGEST_SIZE]; /* sha1/md5 measurement hash */
@@ -79,6 +106,8 @@ void ima_add_violation(struct file *file, const unsigned char *filename,
79106
const char *op, const char *cause);
80107
int ima_init_crypto(void);
81108

109+
int ima_init_template(void);
110+
82111
/*
83112
* used to protect h_table and sha_table
84113
*/

security/integrity/ima/ima_init.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,10 @@ int __init ima_init(void)
9999
rc = ima_init_crypto();
100100
if (rc)
101101
return rc;
102+
rc = ima_init_template();
103+
if (rc != 0)
104+
return rc;
105+
102106
ima_add_boot_aggregate(); /* boot aggregate must be first entry */
103107
ima_init_policy();
104108

security/integrity/ima/ima_template.c

Lines changed: 112 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,112 @@
1+
/*
2+
* Copyright (C) 2013 Politecnico di Torino, Italy
3+
* TORSEC group -- http://security.polito.it
4+
*
5+
* Author: Roberto Sassu <[email protected]>
6+
*
7+
* This program is free software; you can redistribute it and/or
8+
* modify it under the terms of the GNU General Public License as
9+
* published by the Free Software Foundation, version 2 of the
10+
* License.
11+
*
12+
* File: ima_template.c
13+
* Helpers to manage template descriptors.
14+
*/
15+
#include "ima.h"
16+
17+
static struct ima_template_desc defined_templates[] = {
18+
};
19+
20+
static struct ima_template_field supported_fields[] = {
21+
};
22+
23+
static struct ima_template_field *ima_lookup_template_field(
24+
const char *field_id)
25+
{
26+
int i;
27+
28+
for (i = 0; i < ARRAY_SIZE(supported_fields); i++)
29+
if (strncmp(supported_fields[i].field_id, field_id,
30+
IMA_TEMPLATE_FIELD_ID_MAX_LEN) == 0)
31+
return &supported_fields[i];
32+
return NULL;
33+
}
34+
35+
static int ima_template_fmt_size(char *template_fmt)
36+
{
37+
char c;
38+
int template_fmt_len = strlen(template_fmt);
39+
int i = 0, j = 0;
40+
41+
while (i < template_fmt_len) {
42+
c = template_fmt[i];
43+
if (c == '|')
44+
j++;
45+
i++;
46+
}
47+
48+
return j + 1;
49+
}
50+
51+
static int template_desc_init_fields(char *template_fmt,
52+
struct ima_template_field ***fields,
53+
int *num_fields)
54+
{
55+
char *c, *template_fmt_ptr = template_fmt;
56+
int template_num_fields = ima_template_fmt_size(template_fmt);
57+
int i, result = 0;
58+
59+
if (template_num_fields > IMA_TEMPLATE_NUM_FIELDS_MAX)
60+
return -EINVAL;
61+
62+
*fields = kzalloc(template_num_fields * sizeof(*fields), GFP_KERNEL);
63+
if (*fields == NULL) {
64+
result = -ENOMEM;
65+
goto out;
66+
}
67+
for (i = 0; (c = strsep(&template_fmt_ptr, "|")) != NULL &&
68+
i < template_num_fields; i++) {
69+
struct ima_template_field *f = ima_lookup_template_field(c);
70+
71+
if (!f) {
72+
result = -ENOENT;
73+
goto out;
74+
}
75+
(*fields)[i] = f;
76+
}
77+
*num_fields = i;
78+
return 0;
79+
out:
80+
kfree(*fields);
81+
*fields = NULL;
82+
return result;
83+
}
84+
85+
static int init_defined_templates(void)
86+
{
87+
int i = 0;
88+
int result = 0;
89+
90+
/* Init defined templates. */
91+
for (i = 0; i < ARRAY_SIZE(defined_templates); i++) {
92+
struct ima_template_desc *template = &defined_templates[i];
93+
94+
result = template_desc_init_fields(template->fmt,
95+
&(template->fields),
96+
&(template->num_fields));
97+
if (result < 0)
98+
return result;
99+
}
100+
return result;
101+
}
102+
103+
int ima_init_template(void)
104+
{
105+
int result;
106+
107+
result = init_defined_templates();
108+
if (result < 0)
109+
return result;
110+
111+
return 0;
112+
}

0 commit comments

Comments
 (0)