Skip to content

Commit d1c17d8

Browse files
Carolyn WybornyJeff Kirsher
Carolyn Wyborny
authored and
Jeff Kirsher
committed
igb: Fix master/slave mode for all m88 i354 PHY's
This patch calls code to set the master/slave mode for all m88 gen 2 PHY's. This patch also removes the call to this function for I210 devices only from the function that is not called by I210 devices. Signed-off-by: Carolyn Wyborny <[email protected]> Tested-by: Jeff Pieper <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 718bd44 commit d1c17d8

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

drivers/net/ethernet/intel/igb/e1000_phy.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -708,11 +708,6 @@ s32 igb_copper_link_setup_m88(struct e1000_hw *hw)
708708
hw_dbg("Error committing the PHY changes\n");
709709
goto out;
710710
}
711-
if (phy->type == e1000_phy_i210) {
712-
ret_val = igb_set_master_slave_mode(hw);
713-
if (ret_val)
714-
return ret_val;
715-
}
716711

717712
out:
718713
return ret_val;
@@ -806,6 +801,9 @@ s32 igb_copper_link_setup_m88_gen2(struct e1000_hw *hw)
806801
hw_dbg("Error committing the PHY changes\n");
807802
return ret_val;
808803
}
804+
ret_val = igb_set_master_slave_mode(hw);
805+
if (ret_val)
806+
return ret_val;
809807

810808
return 0;
811809
}

0 commit comments

Comments
 (0)