Skip to content

Commit 01cfac0

Browse files
andreabedinihamishmackmergify[bot]
authored
Revert #3639 (Don't pass -package-db and -package flags to --abi-hash) (#9384)
* Revert #3639 (Don't pass -package-db and -package flags to --abi-hash) With ghc>=9.6 `ghc --abi-hash` initialises the plugins so it will fail if a cabal file specifies `ghc-options: -fplugin=Foo`. Closes: #9375 * Also revert in GHC.hs --------- Co-authored-by: Hamish Mackenzie <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
1 parent 4e20249 commit 01cfac0

File tree

2 files changed

+2
-18
lines changed

2 files changed

+2
-18
lines changed

Cabal/src/Distribution/Simple/GHC.hs

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2052,20 +2052,12 @@ libAbiHash verbosity _pkg_descr lbi lib clbi = do
20522052
libBi = libBuildInfo lib
20532053
comp = compiler lbi
20542054
platform = hostPlatform lbi
2055-
vanillaArgs0 =
2055+
vanillaArgs =
20562056
(componentGhcOptions verbosity lbi libBi clbi (componentBuildDir lbi clbi))
20572057
`mappend` mempty
20582058
{ ghcOptMode = toFlag GhcModeAbiHash
20592059
, ghcOptInputModules = toNubListR $ exposedModules lib
20602060
}
2061-
vanillaArgs =
2062-
-- Package DBs unnecessary, and break ghc-cabal. See #3633
2063-
-- BUT, put at least the global database so that 7.4 doesn't
2064-
-- break.
2065-
vanillaArgs0
2066-
{ ghcOptPackageDBs = [GlobalPackageDB]
2067-
, ghcOptPackages = mempty
2068-
}
20692061
sharedArgs =
20702062
vanillaArgs
20712063
`mappend` mempty

Cabal/src/Distribution/Simple/GHCJS.hs

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1739,20 +1739,12 @@ libAbiHash verbosity _pkg_descr lbi lib clbi = do
17391739
libBi = libBuildInfo lib
17401740
comp = compiler lbi
17411741
platform = hostPlatform lbi
1742-
vanillaArgs0 =
1742+
vanillaArgs =
17431743
(componentGhcOptions verbosity lbi libBi clbi (componentBuildDir lbi clbi))
17441744
`mappend` mempty
17451745
{ ghcOptMode = toFlag GhcModeAbiHash
17461746
, ghcOptInputModules = toNubListR $ exposedModules lib
17471747
}
1748-
vanillaArgs =
1749-
-- Package DBs unnecessary, and break ghc-cabal. See #3633
1750-
-- BUT, put at least the global database so that 7.4 doesn't
1751-
-- break.
1752-
vanillaArgs0
1753-
{ ghcOptPackageDBs = [GlobalPackageDB]
1754-
, ghcOptPackages = mempty
1755-
}
17561748
sharedArgs =
17571749
vanillaArgs
17581750
`mappend` mempty

0 commit comments

Comments
 (0)