Skip to content

Commit 18d8018

Browse files
authored
Unmark foreign lib test as broken for win and ghc >= 9.0 (#8111)
* Unmark foreign lib test as broken for win It seems #7764 fixed the test, but the pr was merged without having the ci green * Add changelog for #7763, #7764 and #8111
1 parent bd24cac commit 18d8018

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

cabal-testsuite/PackageTests/ForeignLibs/setup.test.hs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@ main = setupAndCabalTest . recordMode DoNotRecord $ do
2828
skipUnlessGhcVersion ">= 7.8"
2929
osx <- isOSX
3030
ghc80 <- isGhcVersion "== 8.0.2"
31-
win <- isWindows
32-
ghcGreaterThan90 <- isGhcVersion ">= 9.0"
33-
expectBrokenIf ((osx && ghc80) || (win && ghcGreaterThan90)) 7989 $
31+
expectBrokenIf (osx && ghc80) 7989 $
3432
withPackageDb $ do
3533
setup_install []
3634
setup "copy" [] -- regression test #4156

changelog.d/pr-7764

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
synopsis: Use ghc -flink-rts option when available
2+
packages: Cabal
3+
prs: #7764 #8111
4+
issues: #7763
5+
significance: significant
6+
7+
description: {
8+
9+
Previously Cabal did quite some headstands to link against libHSrts.
10+
Note only this is complex but it couples very tightly to GHC's implementation.
11+
Thankfully, as of GHC 9.0 GHC provides a -flink-rts flag for precisely this purpose.
12+
Use it when available.
13+
14+
It fixed a bug which make Cabal unusable to build foreign libraries for windows and ghc 9.0 or 9.2.
15+
See <https://gitlab.haskell.org/ghc/ghc/-/issues/20520>
16+
17+
}

0 commit comments

Comments
 (0)