Skip to content

Commit 679812d

Browse files
committed
Comment on #2971 at the relevant place needing a fix.
Signed-off-by: Edward Z. Yang <[email protected]>
1 parent e250bcc commit 679812d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

Cabal/Distribution/Simple/PreProcess.hs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -448,6 +448,12 @@ ppHsc2hs bi lbi =
448448
++ ["-o", outFile, inFile]
449449
}
450450
where
451+
-- TODO: installedPkgs contains ALL dependencies associated with
452+
-- the package, but we really only want to look at packages for the
453+
-- *current* dependency. We should use PackageIndex.dependencyClosure
454+
-- on the direct depends of the component. Can't easily do that,
455+
-- because the signature of this function is wrong. Tracked with
456+
-- #2971 (which has a test case.)
451457
pkgs = PackageIndex.topologicalOrder (packageHacks (installedPkgs lbi))
452458
isOSX = case buildOS of OSX -> True; _ -> False
453459
isELF = case buildOS of OSX -> False; Windows -> False; AIX -> False; _ -> True;

0 commit comments

Comments
 (0)