Skip to content

Commit 7a511c2

Browse files
committed
make validate.yml consistent with master
1 parent 0cae040 commit 7a511c2

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

.github/workflows/validate.yml

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -66,18 +66,20 @@ jobs:
6666
GHC_FOR_RELEASE: ${{ format('["{0}"]', env.GHC_FOR_RELEASE) }}
6767
strategy:
6868
matrix:
69-
os: ['ubuntu-latest', 'macos-13', 'windows-latest']
70-
# If you remove something from here.. then add it to the old-ghcs job.
69+
os: [ubuntu-latest, macos-13, windows-latest]
70+
# If you remove something from here, then add it to the old-ghcs job.
71+
# Also a removed GHC from here means that we are actually dropping
72+
# support, so the PR *must* have a changelog entry.
7173
ghc: ['9.8.2', '9.6.4', '9.4.8', '9.2.8', '9.0.2', '8.10.7', '8.8.4', '8.6.5']
7274
exclude:
7375
# corrupts GHA cache or the fabric of reality itself, see https://github.com/haskell/cabal/issues/8356
74-
- os: 'windows-latest'
76+
- os: windows-latest
7577
ghc: '8.10.7'
7678
# lot of segfaults caused by ghc bugs
77-
- os: 'windows-latest'
79+
- os: windows-latest
7880
ghc: '8.8.4'
7981
# it often randomly does "C:\Users\RUNNER~1\AppData\Local\Temp\ghcFEDE.c: DeleteFile "\\\\?\\C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\ghcFEDE.c": permission denied (Access is denied.)"
80-
- os: 'windows-latest'
82+
- os: windows-latest
8183
ghc: '8.6.5'
8284

8385
steps:
@@ -210,7 +212,7 @@ jobs:
210212

211213
validate-old-ghcs:
212214
name: Validate old ghcs ${{ matrix.extra-ghc }}
213-
runs-on: 'ubuntu-latest'
215+
runs-on: ubuntu-latest
214216
needs: validate
215217

216218
strategy:
@@ -269,7 +271,7 @@ jobs:
269271

270272
build-alpine:
271273
name: Build statically linked using alpine
272-
runs-on: 'ubuntu-latest'
274+
runs-on: ubuntu-latest
273275
container: 'alpine:3.19'
274276
steps:
275277
- name: Install extra dependencies
@@ -340,7 +342,7 @@ jobs:
340342
needs: validate
341343
strategy:
342344
matrix:
343-
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
345+
os: [ubuntu-latest, macos-latest, windows-latest]
344346
# We only use one ghc version the used one for the next release (defined at top of the workflow)
345347
# We need to build an array dynamically to inject the appropiate env var in a previous job,
346348
# see https://docs.github.com/en/actions/learn-github-actions/expressions#fromjson
@@ -380,11 +382,11 @@ jobs:
380382

381383
prerelease-head:
382384
name: Create a GitHub prerelease with the binary artifacts
383-
runs-on: 'ubuntu-latest'
385+
runs-on: ubuntu-latest
384386
if: github.ref == 'refs/heads/master'
385387

386388
# IMPORTANT! Any job added to the workflow should be added here too
387-
needs: ['validate', 'validate-old-ghcs', 'build-alpine', 'dogfooding']
389+
needs: [validate, validate-old-ghcs, build-alpine, dogfooding]
388390

389391
steps:
390392
- uses: actions/download-artifact@v3
@@ -423,9 +425,9 @@ jobs:
423425
validate-post-job:
424426
if: always()
425427
name: Validate post job
426-
runs-on: 'ubuntu-latest'
428+
runs-on: ubuntu-latest
427429
# IMPORTANT! Any job added to the workflow should be added here too
428-
needs: ['validate', 'validate-old-ghcs', 'build-alpine', 'dogfooding']
430+
needs: [validate, validate-old-ghcs, build-alpine, dogfooding]
429431

430432
steps:
431433
- run: |

0 commit comments

Comments
 (0)