Skip to content

Commit 8063cd8

Browse files
authored
Merge pull request #7866 from andreasabel/haddock-verbose-stderr
Haddockumentation fixes to Cabal::Distribution.Verbosity.
2 parents 022cfaa + 226f9b2 commit 8063cd8

File tree

2 files changed

+20
-16
lines changed

2 files changed

+20
-16
lines changed

Cabal/src/Distribution/Simple/Utils.hs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -457,6 +457,7 @@ displaySomeException se =
457457
topHandler :: IO a -> IO a
458458
topHandler prog = topHandlerWith (const $ exitWith (ExitFailure 1)) prog
459459

460+
-- | Depending on 'isVerboseStderr', set the output handle to 'stderr' or 'stdout'.
460461
verbosityHandle :: Verbosity -> Handle
461462
verbosityHandle verbosity
462463
| isVerboseStderr verbosity = stderr

Cabal/src/Distribution/Verbosity.hs

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ module Distribution.Verbosity (
4242
verboseMarkOutput, isVerboseMarkOutput,
4343
verboseUnmarkOutput,
4444

45-
-- * line-wrapping
45+
-- * Line wrapping
4646
verboseNoWrap, isVerboseNoWrap,
4747

48-
-- * timestamps
48+
-- * Time stamps
4949
verboseTimestamp, isVerboseTimestamp,
5050
verboseNoTimestamp,
5151

@@ -98,23 +98,24 @@ instance Bounded Verbosity where
9898
instance Binary Verbosity
9999
instance Structured Verbosity
100100

101-
-- We shouldn't print /anything/ unless an error occurs in silent mode
101+
-- | In 'silent' mode, we should not print /anything/ unless an error occurs.
102102
silent :: Verbosity
103103
silent = mkVerbosity Silent
104104

105-
-- Print stuff we want to see by default
105+
-- | Print stuff we want to see by default.
106106
normal :: Verbosity
107107
normal = mkVerbosity Normal
108108

109-
-- Be more verbose about what's going on
109+
-- | Be more verbose about what's going on.
110110
verbose :: Verbosity
111111
verbose = mkVerbosity Verbose
112112

113-
-- Not only are we verbose ourselves (perhaps even noisier than when
114-
-- being "verbose"), but we tell everything we run to be verbose too
113+
-- | Not only are we verbose ourselves (perhaps even noisier than when
114+
-- being 'verbose'), but we tell everything we run to be verbose too.
115115
deafening :: Verbosity
116116
deafening = mkVerbosity Deafening
117117

118+
-- | Increase verbosity level, but stay 'silent' if we are.
118119
moreVerbose :: Verbosity -> Verbosity
119120
moreVerbose v =
120121
case vLevel v of
@@ -123,6 +124,7 @@ moreVerbose v =
123124
Verbose -> v { vLevel = Deafening }
124125
Deafening -> v
125126

127+
-- | Decrease verbosity level, but stay 'deafening' if we are.
126128
lessVerbose :: Verbosity -> Verbosity
127129
lessVerbose v =
128130
verboseQuiet $
@@ -146,6 +148,7 @@ lessVerbose v =
146148
modifyVerbosity :: (Verbosity -> Verbosity) -> Verbosity -> Verbosity
147149
modifyVerbosity f v = v { vLevel = vLevel (f v) }
148150

151+
-- | Numeric verbosity level @0..3@: @0@ is 'silent', @3@ is 'deafening'.
149152
intToVerbosity :: Int -> Maybe Verbosity
150153
intToVerbosity 0 = Just (mkVerbosity Silent)
151154
intToVerbosity 1 = Just (mkVerbosity Normal)
@@ -271,7 +274,7 @@ verboseUnmarkOutput = verboseNoFlag VMarkOutput
271274
verboseNoWrap :: Verbosity -> Verbosity
272275
verboseNoWrap = verboseFlag VNoWrap
273276

274-
-- | Mark the verbosity as quiet
277+
-- | Mark the verbosity as quiet.
275278
verboseQuiet :: Verbosity -> Verbosity
276279
verboseQuiet v = v { vQuiet = True }
277280

@@ -283,31 +286,31 @@ verboseTimestamp = verboseFlag VTimestamp
283286
verboseNoTimestamp :: Verbosity -> Verbosity
284287
verboseNoTimestamp = verboseNoFlag VTimestamp
285288

286-
-- | Turn on timestamps for log messages.
289+
-- | Switch logging to 'stderr'.
287290
--
288291
-- @since 3.4.0.0
289292
verboseStderr :: Verbosity -> Verbosity
290293
verboseStderr = verboseFlag VStderr
291294

292-
-- | Turn off timestamps for log messages.
295+
-- | Switch logging to 'stdout'.
293296
--
294297
-- @since 3.4.0.0
295298
verboseNoStderr :: Verbosity -> Verbosity
296299
verboseNoStderr = verboseNoFlag VStderr
297300

298-
-- | Turn off warnings for log messages
301+
-- | Turn off warnings for log messages.
299302
verboseNoWarn :: Verbosity -> Verbosity
300303
verboseNoWarn = verboseFlag VNoWarn
301304

302-
-- | Helper function for flag enabling functions
305+
-- | Helper function for flag enabling functions.
303306
verboseFlag :: VerbosityFlag -> (Verbosity -> Verbosity)
304307
verboseFlag flag v = v { vFlags = Set.insert flag (vFlags v) }
305308

306-
-- | Helper function for flag disabling functions
309+
-- | Helper function for flag disabling functions.
307310
verboseNoFlag :: VerbosityFlag -> (Verbosity -> Verbosity)
308311
verboseNoFlag flag v = v { vFlags = Set.delete flag (vFlags v) }
309312

310-
-- | Turn off all flags
313+
-- | Turn off all flags.
311314
verboseNoFlags :: Verbosity -> Verbosity
312315
verboseNoFlags v = v { vFlags = Set.empty }
313316

@@ -330,15 +333,15 @@ isVerboseMarkOutput = isVerboseFlag VMarkOutput
330333
isVerboseNoWrap :: Verbosity -> Bool
331334
isVerboseNoWrap = isVerboseFlag VNoWrap
332335

333-
-- | Test if we had called 'lessVerbose' on the verbosity
336+
-- | Test if we had called 'lessVerbose' on the verbosity.
334337
isVerboseQuiet :: Verbosity -> Bool
335338
isVerboseQuiet = vQuiet
336339

337340
-- | Test if we should output timestamps when we log.
338341
isVerboseTimestamp :: Verbosity -> Bool
339342
isVerboseTimestamp = isVerboseFlag VTimestamp
340343

341-
-- | Test if we should output to stderr when we log.
344+
-- | Test if we should output to 'stderr' when we log.
342345
--
343346
-- @since 3.4.0.0
344347
isVerboseStderr :: Verbosity -> Bool

0 commit comments

Comments
 (0)