Skip to content

Commit 976f86a

Browse files
authored
Merge pull request #9397 from fendor/ci/issue-8365
Add dependencies used by `PackageTests` to exe:cabal-tests
2 parents 6330967 + b83cc31 commit 976f86a

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

cabal-testsuite/cabal-testsuite.cabal

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,18 @@ executable cabal-tests
101101
, transformers
102102
-- dependencies specific to exe:cabal-tests
103103
, clock ^>= 0.7.2 || ^>=0.8
104+
-- Extra dependencies used by PackageTests.
105+
--
106+
-- The runner allows the tests to use extra dependencies and the custom Prelude
107+
-- from 'cabal-testsuite'.
108+
-- However, if the tests use a dependency, say 'directory', and there are two
109+
-- packages with the same unit id available in the store, the test fails since
110+
-- it doesn't know which one to pick.
111+
-- By including an extra dependency to directory, we force the test runner to
112+
-- use a specific version directory, fixing the test failure.
113+
--
114+
-- See issue description and discussion: https://github.com/haskell/cabal/issues/8356
115+
, directory
104116

105117
build-tool-depends: cabal-testsuite:setup
106118
default-extensions: TypeOperators

0 commit comments

Comments
 (0)