Skip to content

Commit d4e43fc

Browse files
committed
Remove unnecessary -fvia-C check
Brandon’s review/II.
1 parent a051dd6 commit d4e43fc

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

Cabal/src/Distribution/PackageDescription/Check/Target.hs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -802,9 +802,6 @@ checkGHCOptions title t opts = do
802802
checkFlags
803803
["-fasm"]
804804
(PackageDistInexcusable $ OptFasm title)
805-
checkFlags
806-
["-fvia-C"]
807-
(PackageDistSuspicious $ OptViaC title)
808805
checkFlags
809806
["-fhpc"]
810807
(PackageDistInexcusable $ OptHpc title)

Cabal/src/Distribution/PackageDescription/Check/Warning.hs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ data CheckExplanation
164164
| SubdirRelPath
165165
| SubdirGoodRelPath String
166166
| OptFasm String
167-
| OptViaC String
168167
| OptHpc String
169168
| OptProf String
170169
| OptO String
@@ -520,13 +519,6 @@ ppExplanation (OptFasm fieldName) =
520519
++ fieldName
521520
++ ": -fasm' is unnecessary and will not work on CPU "
522521
++ "architectures other than x86, x86-64, ppc or sparc."
523-
ppExplanation (OptViaC fieldName) =
524-
"'"
525-
++ fieldName
526-
++ ": -fvia-C' is usually unnecessary. If your package "
527-
++ "needs -via-C for correctness rather than performance then it "
528-
++ "is using the FFI incorrectly and will probably not work with GHC "
529-
++ "6.10 or later."
530522
ppExplanation (OptHpc fieldName) =
531523
"'"
532524
++ fieldName

0 commit comments

Comments
 (0)