Skip to content

Add solver input to make enabling test/benchmark stanzas automatic rather than just manual #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcoutts opened this issue Oct 29, 2015 · 7 comments

Comments

@dcoutts
Copy link
Contributor

dcoutts commented Oct 29, 2015

Currently in the solver we have flags and stanzas which have significant similarities.

Flags guard arbitrary additional dependencies and can either be specified up front manually or they can be variables that are solved for. Stanzas guard additional dependencies (for tests and benchmarks) and whether they are enabled or disabled is specified up front.

The task is to add an automatic mode to the stanzas case. That is, just like flags, whether a stanzas is enabled or not could be specified up front or it could be solved for.

This shouldn't be too hard since stanzas and flags are already treated very similarly in the solver, and flags already have this feature, so it should be a matter of some copying to add the feature to stanzas too.

The motivation is that some new code wants to run the solver in a way to enable testsuites and benchmarks if possible, but turn them off if not possible (and sometimes manually force enable/disable).

@kosmikus
Copy link
Contributor

This is probably relatively easy, so it might be interesting for someone who wants to gain more experience in hacking on the solver.

@dcoutts
Copy link
Contributor Author

dcoutts commented Nov 2, 2015

See PR #2907

@grayjay
Copy link
Collaborator

grayjay commented Jan 29, 2016

Was this fixed in #3092?

@ezyang
Copy link
Contributor

ezyang commented Mar 31, 2016

@grayjay I don't think so, at the very least you need to add a command line to toggle behavior.

@grayjay
Copy link
Collaborator

grayjay commented Jun 17, 2016

@dcoutts Do you know what else needs to be done for this issue?

@kosmikus
Copy link
Contributor

kosmikus commented Jul 4, 2016

I'm confused. I thought that the purpose of #3092 was indeed to enable this, but that it was never the intention to enable tests/benchmarks completely automatically. Instead, I think the idea is to run the solver in such a way that it tries to find an install plan that would be compatible with enabling tests and benchmarks. If you then later decide to enable them (which still has to be done manually), then ideally, you'll just end up installing a few additional packages, rather than a completely different set of packages.

So the motivation, as far as I understood dcoutts, was to gain a certain amount of stability between enabling and disabling tests/benchs and the respective install plans, not to actually enable them fully automatically.

@dcoutts
Copy link
Contributor Author

dcoutts commented Aug 31, 2016

Was this fixed in #3092?

Yes it was.

@dcoutts dcoutts closed this as completed Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants