Skip to content

new-install symlink location #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fgaz opened this issue Jan 6, 2018 · 4 comments
Closed

new-install symlink location #5000

fgaz opened this issue Jan 6, 2018 · 4 comments

Comments

@fgaz
Copy link
Member

fgaz commented Jan 6, 2018

Currently new-install errors out without additional flags because it uses symlink-bindir as symlink location, which is unset by default. I actually am not sure what that flag was supposed to do originally (can someone clarify? Is the current behavior the intended one?).

After some digging I found that bindir is the only flag that is automatically set to ~/.cabal/bin in the config file.

Now there are two courses of action:

  1. set symlink-bindir to ~/.cabal/bin and equivalents on config creation
  2. use bindir instead

The downside of (1) is that existing configurations will not have that flag set and will give an error. edit: well, I just discovered cabal user-config update
The downside of (2) is that the bindir flag serves an obvious purpose for packagers, and using it for the symlink and not the executable violates that.

I think (1) is the correct one, maybe with a default to address the empty flag problem, but I'd like to hear some opinions first.

We should also document symlink-bindir here

@fgaz fgaz added this to the 2.2 milestone Jan 6, 2018
@fgaz fgaz self-assigned this Jan 6, 2018
@fgaz fgaz changed the title new-install install location new-install symlink location Jan 6, 2018
@23Skidoo
Copy link
Member

23Skidoo commented Jan 8, 2018

Congrats on the 5000 get, by the way.

@ezyang
Copy link
Contributor

ezyang commented Jan 8, 2018

(1) seems OK to me, esp if the error message when it is unset explains how to unwedge your config.

@fgaz
Copy link
Member Author

fgaz commented Jan 16, 2018

@dcoutts you seem to be the author of symlink-bindir 2eddc49

Is the first option here correct?

@angerman
Copy link
Collaborator

I'm in favor of (1) as well.


Wow, 2eddc49 is almost 10 years old!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants