0.5.0.0: Could not fetch submodules

[unclechu]

λ git branch
* (HEAD detached at 0.5.0.0)
  master

λ git submodule update
Submodule path 'submodules/HaRe': checked out '53979f062bebcaa132390d1fd0cec74a51662952'
error: Server does not allow request for unadvertised object 6c187da8f8166d595f36d6aaf419370283b3d1e9
Fetched in submodule path 'submodules/brittany', but it did not contain 6c187da8f8166d595f36d6aaf419370283b3d1e9. Direct fetching of that commit failed.

[lukel97]

Try git submodule sync --recursive before doing git submodule update

[unclechu]

It is some force-pusher's job? I just checkout brittany to master branch manually and make build-all is succeeded.

[lukel97]

I'm not sure if anyone force-pushed, 6c187da8f8166d595f36d6aaf419370283b3d1e9 is the correct hash for the current commit. The remote did change recently though which is probably what threw it off:
870e7c9#diff-8903239df476d7401cf9e76af0252622

[unclechu]

I just did fresh --recursive clone of a repo and this went okay. I'm not sure what kind of this issue is. @bubba May be git submodule sync --recursive supposed to be added to Makefile or something? To avoid such issues in the future, since it make build-all is failing, and it does git submodule update which fails, I just pulled fresh 0.5.0.0 branch in existing repo.

[lukel97]

@unclechu looks like the Makefile already had a step to sync the submodules but it didn't use --recursive. Thanks for spotting this, I've created a PR for it: #1032