Skip to content

Commit 24ec53a

Browse files
peterwicksstringfieldpepeiborrajneiramergify[bot]
authored
Update links to issues/PRs in ghcide tests. (#1142)
All ghcide issues have been transferred to HLS. All PRs open at ghcide archive time were transferred, but closed and merged ghcide PRs were left behind. Before this commit we have: 1. Full links. 2. Numbers like "#xxx" or "-- xxx", referring to ghcide issues/PRs. After this commit we have: 1. Full links. 2. Numbers like "#xxx" or "-- xxx", referring to HLS issues/PRs. Note: "ghcide#xxx" and "hls#yyy" are unambiguous, github will never make an issue and PR in the same repository with the same number. Note: "#xxx" is definitely ambiguous, there can be a "ghcide#xxx" and an "hls#xxx" which are totally unrelated. One could even be an issue while the other is a pull request. Relevant mappings: ghcide#7 |-> hls#1129 ghcide#71 |-> hls#1102 ghcide#123 |-> hls#713 ghcide#137 |-> hls#1073 ghcide#246 |-> hls#1030 ghcide#247 |-> hls#1029 ghcide#248 |-> hls#1028 ghcide#249 |-> hls#717 ghcide#250 |-> hls#1027 ghcide#273 |-> hls#1017 ghcide#274 |-> hls#1016 ghcide#283 |-> hls#1012 ghcide#310 |-> hls#767 ghcide#315 |-> hls#1002 ghcide#614 |-> hls#891 ghcide#847 |-> hls#831 Co-authored-by: Pepe Iborra <[email protected]> Co-authored-by: Javier Neira <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
1 parent 0b0a6a7 commit 24ec53a

File tree

1 file changed

+34
-34
lines changed

1 file changed

+34
-34
lines changed

‎ghcide/test/exe/Main.hs

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -2523,45 +2523,45 @@ findDefinitionAndHoverTests = let
25232523
mkFindTests
25242524
-- def hover look expect
25252525
[ test yes yes fffL4 fff "field in record definition"
2526-
, test yes yes fffL8 fff "field in record construction #71"
2527-
, test yes yes fffL14 fff "field name used as accessor" -- 120 in Calculate.hs
2528-
, test yes yes aaaL14 aaa "top-level name" -- 120
2529-
, test yes yes dcL7 tcDC "data constructor record #247"
2530-
, test yes yes dcL12 tcDC "data constructor plain" -- 121
2531-
, test yes yes tcL6 tcData "type constructor #248" -- 147
2532-
, test broken yes xtcL5 xtc "type constructor external #248,249"
2533-
, test broken yes xvL20 xvMsg "value external package #249" -- 120
2534-
, test yes yes vvL16 vv "plain parameter" -- 120
2535-
, test yes yes aL18 apmp "pattern match name" -- 120
2536-
, test yes yes opL16 op "top-level operator" -- 120, 123
2537-
, test yes yes opL18 opp "parameter operator" -- 120
2538-
, test yes yes b'L19 bp "name in backticks" -- 120
2539-
, test yes yes clL23 cls "class in instance declaration #250"
2540-
, test yes yes clL25 cls "class in signature #250" -- 147
2541-
, test broken yes eclL15 ecls "external class in signature #249,250"
2542-
, test yes yes dnbL29 dnb "do-notation bind" -- 137
2526+
, test yes yes fffL8 fff "field in record construction #1102"
2527+
, test yes yes fffL14 fff "field name used as accessor" -- https://github.com/haskell/ghcide/pull/120 in Calculate.hs
2528+
, test yes yes aaaL14 aaa "top-level name" -- https://github.com/haskell/ghcide/pull/120
2529+
, test yes yes dcL7 tcDC "data constructor record #1029"
2530+
, test yes yes dcL12 tcDC "data constructor plain" -- https://github.com/haskell/ghcide/pull/121
2531+
, test yes yes tcL6 tcData "type constructor #1028" -- https://github.com/haskell/ghcide/pull/147
2532+
, test broken yes xtcL5 xtc "type constructor external #717,1028"
2533+
, test broken yes xvL20 xvMsg "value external package #717" -- https://github.com/haskell/ghcide/pull/120
2534+
, test yes yes vvL16 vv "plain parameter" -- https://github.com/haskell/ghcide/pull/120
2535+
, test yes yes aL18 apmp "pattern match name" -- https://github.com/haskell/ghcide/pull/120
2536+
, test yes yes opL16 op "top-level operator #713" -- https://github.com/haskell/ghcide/pull/120
2537+
, test yes yes opL18 opp "parameter operator" -- https://github.com/haskell/ghcide/pull/120
2538+
, test yes yes b'L19 bp "name in backticks" -- https://github.com/haskell/ghcide/pull/120
2539+
, test yes yes clL23 cls "class in instance declaration #1027"
2540+
, test yes yes clL25 cls "class in signature #1027" -- https://github.com/haskell/ghcide/pull/147
2541+
, test broken yes eclL15 ecls "external class in signature #717,1027"
2542+
, test yes yes dnbL29 dnb "do-notation bind #1073"
25432543
, test yes yes dnbL30 dnb "do-notation lookup"
2544-
, test yes yes lcbL33 lcb "listcomp bind" -- 137
2544+
, test yes yes lcbL33 lcb "listcomp bind #1073"
25452545
, test yes yes lclL33 lcb "listcomp lookup"
25462546
, test yes yes mclL36 mcl "top-level fn 1st clause"
2547-
, test yes yes mclL37 mcl "top-level fn 2nd clause #246"
2547+
, test yes yes mclL37 mcl "top-level fn 2nd clause #1030"
25482548
#if MIN_GHC_API_VERSION(8,10,0)
2549-
, test yes yes spaceL37 space "top-level fn on space #315"
2549+
, test yes yes spaceL37 space "top-level fn on space #1002"
25502550
#else
2551-
, test yes broken spaceL37 space "top-level fn on space #315"
2551+
, test yes broken spaceL37 space "top-level fn on space #1002"
25522552
#endif
2553-
, test no yes docL41 doc "documentation #7"
2554-
, test no yes eitL40 kindE "kind of Either #273"
2555-
, test no yes intL40 kindI "kind of Int #273"
2556-
, test no broken tvrL40 kindV "kind of (* -> *) type variable #273"
2557-
, test no broken intL41 litI "literal Int in hover info #274"
2558-
, test no broken chrL36 litC "literal Char in hover info #274"
2559-
, test no broken txtL8 litT "literal Text in hover info #274"
2560-
, test no broken lstL43 litL "literal List in hover info #274"
2561-
, test no broken docL41 constr "type constraint in hover info #283"
2562-
, test broken broken outL45 outSig "top-level signature #310"
2563-
, test broken broken innL48 innSig "inner signature #310"
2564-
, test no yes holeL60 hleInfo "hole without internal name #847"
2553+
, test no yes docL41 doc "documentation #1129"
2554+
, test no yes eitL40 kindE "kind of Either #1017"
2555+
, test no yes intL40 kindI "kind of Int #1017"
2556+
, test no broken tvrL40 kindV "kind of (* -> *) type variable #1017"
2557+
, test no broken intL41 litI "literal Int in hover info #1016"
2558+
, test no broken chrL36 litC "literal Char in hover info #1016"
2559+
, test no broken txtL8 litT "literal Text in hover info #1016"
2560+
, test no broken lstL43 litL "literal List in hover info #1016"
2561+
, test no broken docL41 constr "type constraint in hover info #1012"
2562+
, test broken broken outL45 outSig "top-level signature #767"
2563+
, test broken broken innL48 innSig "inner signature #767"
2564+
, test no yes holeL60 hleInfo "hole without internal name #831"
25652565
, test no skip cccL17 docLink "Haddock html links"
25662566
, testM yes yes imported importedSig "Imported symbol"
25672567
, testM yes yes reexported reexportedSig "Imported symbol (reexported)"
@@ -2738,7 +2738,7 @@ thTests =
27382738
_ <- createDoc "B.hs" "haskell" sourceB
27392739
return ()
27402740
, thReloadingTest
2741-
-- Regression test for https://github.com/haskell/ghcide/issues/614
2741+
-- Regression test for https://github.com/haskell/haskell-language-server/issues/891
27422742
, thLinkingTest
27432743
, testSessionWait "findsTHIdentifiers" $ do
27442744
let sourceA =

0 commit comments

Comments
 (0)