Skip to content

Commit 9223599

Browse files
authored
Ignore flakey tactics test (#546)
Due to an oversight in how we handle polymorphic class methods (fixed in #537), having an applicative context introduces (*>) into scope, which causes an exponential explosion in the search space. On fast machines it seems like we can get through this test before the timeout, but on CI it's flakey.
1 parent 91d2711 commit 9223599

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

test/functional/Tactic.hs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ module Tactic
99
where
1010

1111
import Control.Applicative.Combinators ( skipManyTill )
12+
import Control.Monad (unless)
1213
import Control.Monad.IO.Class
1314
import Data.Foldable
1415
import Data.Maybe
@@ -18,12 +19,12 @@ import qualified Data.Text.IO as T
1819
import Ide.Plugin.Tactic.TestTypes
1920
import Language.Haskell.LSP.Test
2021
import Language.Haskell.LSP.Types (ApplyWorkspaceEditRequest, Position(..) , Range(..) , CAResult(..) , CodeAction(..))
22+
import System.Directory (doesFileExist)
23+
import System.FilePath
2124
import Test.Hls.Util
2225
import Test.Tasty
26+
import Test.Tasty.ExpectedFailure (ignoreTestBecause)
2327
import Test.Tasty.HUnit
24-
import System.FilePath
25-
import System.Directory (doesFileExist)
26-
import Control.Monad (unless)
2728

2829

2930
------------------------------------------------------------------------------
@@ -106,7 +107,8 @@ tests = testGroup
106107
, goldenTest "GoldenShowCompose.hs" 2 15 Auto ""
107108
, goldenTest "GoldenShowMapChar.hs" 2 8 Auto ""
108109
, goldenTest "GoldenSuperclass.hs" 7 8 Auto ""
109-
, goldenTest "GoldenApplicativeThen.hs" 2 11 Auto ""
110+
, ignoreTestBecause "It is unreliable in circleci builds"
111+
$ goldenTest "GoldenApplicativeThen.hs" 2 11 Auto ""
110112
]
111113

112114

0 commit comments

Comments
 (0)