Skip to content

Commit c8507a0

Browse files
committed
Merge remote-tracking branch 'cydparser/cabal-plugin-ambiguity' into wavewave/ci-nix-build
2 parents 4c518f8 + 095a628 commit c8507a0

File tree

3 files changed

+3
-14
lines changed

3 files changed

+3
-14
lines changed

plugins/hls-cabal-plugin/hls-cabal-plugin.cabal

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,7 @@ library
3333
build-depends:
3434
, base >=4.12 && <5
3535
, bytestring
36-
-- Ideally, we only want to support a single Cabal version, supporting
37-
-- older versions is completely pointless since Cabal is backwards compatible,
38-
-- the latest Cabal version can parse all versions of the Cabal file format.
39-
--
40-
-- However, stack is making this difficult, if we change the version of Cabal,
41-
-- we essentially need to make sure all other packages in the snapshot have their
42-
-- Cabal dependency version relaxed.
43-
-- Most packages have a Hackage revision, but stack won't pick these up (for sensible reasons)
44-
-- automatically, forcing us to manually update the packages revision id.
45-
-- This is a lot of work for almost zero benefit, so we just allow more versions here
46-
-- and we eventually completely drop support for building HLS with stack.
47-
, Cabal ^>=3.2 || ^>=3.4 || ^>=3.6 || ^>= 3.8
48-
, Cabal-syntax ^>= 3.6
36+
, Cabal-syntax ^>= 3.8
4937
, deepseq
5038
, directory
5139
, extra >=1.7.4

stack-lts19.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ ghc-options:
4242
"$everything": -haddock
4343

4444
extra-deps:
45-
- Cabal-3.6.0.0
45+
- Cabal-syntax-3.8.1.0
4646
# needed for tests of hls-cabal-fmt-plugin
4747
- cabal-fmt-0.1.6@sha256:54041d50c8148c32d1e0a67aef7edeebac50ae33571bef22312f6815908eac19,3626
4848
- floskell-0.10.6@sha256:e77d194189e8540abe2ace2c7cb8efafc747ca35881a2fefcbd2d40a1292e036,3819

stack.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ extra-deps:
5252
- lsp-types-1.6.0.0
5353
- lsp-test-0.14.1.0
5454
- hie-bios-0.11.0
55+
- Cabal-syntax-3.8.1.0
5556

5657
# currently needed for ghcide>extra, etc.
5758
allow-newer: true

0 commit comments

Comments
 (0)