Skip to content

Add LSP kinds to "import" code actions #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
isovector opened this issue Mar 11, 2021 · 1 comment · Fixed by #1570
Closed

Add LSP kinds to "import" code actions #1556

isovector opened this issue Mar 11, 2021 · 1 comment · Fixed by #1570
Labels
component: ghcide type: enhancement New feature or request

Comments

@isovector
Copy link
Collaborator

The current "import" code actions are pretty overwhelming, especially for commonly used names. We get the cartesian product of matches x styles.

I'd like to suggest we export import Foo.Blah under the kind quickfix.import.module and import Foo.Blah (what) under quickfix.import.definition. Users can then opt-in to their preferred style, and users/clients who don't care will still see today's behavior.
@berberman berberman mentioned this issue Mar 14, 2021
Merged
@mergify mergify bot closed this as completed in #1570 Mar 15, 2021
@uhbif19
Copy link
Collaborator

uhbif19 commented Apr 19, 2023

How this could be filtered in editor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcide type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add custom code action kinds for import related code actions berberman/haskell-language-server
3 participants
@uhbif19 @isovector @berberman