Skip to content

Suggestion: Use CiInterface as completion item kind for typeclasses #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fwcd opened this issue Mar 16, 2021 · 0 comments · Fixed by #1592
Closed

Suggestion: Use CiInterface as completion item kind for typeclasses #1581

fwcd opened this issue Mar 16, 2021 · 0 comments · Fixed by #1592
Labels

Comments

@fwcd
Copy link
Contributor

fwcd commented Mar 16, 2021

Typeclasses currently use CiClass as completion item kinds. My impression, however, is that most LSP clients (e.g. VSCode) interpret the completion item kind Class to be referring to OOP-style classes, as VSCode's icon suggests:

image

Since Haskell's typeclasses are semantically much closer to OOP interfaces, my suggestion would be to use CiInterface as completion item kind instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants