Skip to content

hls vscode-extension-schema generates a wrong config type #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jneira opened this issue Dec 1, 2021 · 0 comments
Open

hls vscode-extension-schema generates a wrong config type #2423

jneira opened this issue Dec 1, 2021 · 0 comments
Labels
component: cli About the pure command line interface of the hls executable type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@jneira
Copy link
Member

jneira commented Dec 1, 2021

The command outputs for wingaman hole severity option:

 "haskell.plugin.tactics.config.hole_severity": {
        "type": "string",
        "scope": "resource",
        "enumDescriptions": [
            "error",
            "warning",
            "info",
            "hint",
            "none"
        ],
        "default": null,
        "description": "The severity to use when showing hole diagnostics. These
 are noisy, but some editors don't allow jumping to all severities.",
        "enum": [
            1,
            2,
            3,
            4,
            null
        ]
    },

but its type should be integer instead string, as we can check in the enum values. It produced abug in the vscode extension fixed when we changed the type to integer

//cc @berberman @isovector

@jneira jneira added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. component: cli About the pure command line interface of the hls executable labels Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: cli About the pure command line interface of the hls executable type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

1 participant