Migration to text-2.*

[pepeiborra]

There are at least two dependencies that block this migration:

1. lsp-types: Migration to text 2.0 lsp#391
2. bytestring-encoding: Support text 2.0 msakai/bytestring-encoding#6

The first one is obviously a hard requirement, but for the second one there's only one call site so we could consider dropping it:

haskell-language-server/ghcide/src/Development/IDE/Core/Rules.hs

Lines 525 to 537 in d48a1df

	persistentHieFileRule :: Rules ()
	persistentHieFileRule = addPersistentRule GetHieAst $ \file -> runMaybeT $ do
	res <- readHieFileForSrcFromDisk file
	vfs <- asks vfs
	encoding <- liftIO getLocaleEncoding
	(currentSource,ver) <- liftIO $ do
	mvf <- getVirtualFile vfs $ filePathToUri' file
	case mvf of
	Nothing -> (,Nothing) . T.decode encoding <$> BS.readFile (fromNormalizedFilePath file)
	Just vf -> pure (Rope.toText $ _text vf, Just $ _lsp_version vf)
	let refmap = Compat.generateReferencesMap . Compat.getAsts . Compat.hie_asts $ res
	del = deltaFromDiff (T.decode encoding $ Compat.hie_hs_src res) currentSource
	pure (HAR (Compat.hie_module res) (Compat.hie_asts res) refmap mempty (HieFromDisk res),del,ver)

[drsooch]

Looks like retrie needs it's text bounds updated as well?

[Bodigrim]

bytestring-encoding is avoidable: T.decode encoding <$> BS.readFile is just Data.Text.IO.readFile, and T.decode encoding below can be replaced with T.decodeUtf8, because Haskell sources are always in UTF-8.

I've successfully built HLS against text-2.0 with this patch: https://github.com/Bodigrim/haskell-language-server/commit/e14ea011f6386911f678223e87c0b519f7843a3e

[pepeiborra]

@Bodigrim would you be able to send a PR? I will gladly accept it

[pepeiborra]

Looks like retrie needs it's text bounds updated as well?

Opened facebookincubator/retrie#42

[Bodigrim]

@pepeiborra sorry, I'm trying really hard to keep myself away from diving into one more project ;) All you need is this:

+import qualified Data.Text.IO                                 as T
 import           Data.Time                                    (UTCTime (..))
 import           Data.Tuple.Extra
 import           Development.IDE.Core.Compile
@@ -530,10 +530,10 @@ persistentHieFileRule = addPersistentRule GetHieAst $ \file -> runMaybeT $ do
   (currentSource,ver) <- liftIO $ do
     mvf <- getVirtualFile vfs $ filePathToUri' file
     case mvf of
-      Nothing -> (,Nothing) . T.decode encoding <$> BS.readFile (fromNormalizedFilePath file)
+      Nothing -> (,Nothing) <$> T.readFile (fromNormalizedFilePath file)
       Just vf -> pure (Rope.toText $ _text vf, Just $ _lsp_version vf)
   let refmap = Compat.generateReferencesMap . Compat.getAsts . Compat.hie_asts $ res
-      del = deltaFromDiff (T.decode encoding $ Compat.hie_hs_src res) currentSource
+      del = deltaFromDiff (T.decodeUtf8 $ Compat.hie_hs_src res) currentSource

[pepeiborra]

Sent #2628

[Bodigrim]

I've been able to build HLS with text-2.0 and GHC 9.0, using this setup:

constraints:
    text >= 2.0,
    haskell-language-server -brittany -floskell -fourmolu -stylishHaskell

[pepeiborra]

I think we can close this issue and declare victory.

[michaelpj]

I agree.