Request for GHC 9.2.5 support

[peterbecich]

Request for GHC 9.2.5 support and haskell-language-server-9.2.5.

GHC 9.2.5 was released recently: https://www.haskell.org/ghc/download_ghc_9_2_5.html

Thank you

[awgn]

The latest stack LTS 20.1 is based on GHC 9.2.5 and the lack of support for it in HLS prevents users, like me, from switching to the new LTS.

[ttylec]

Moreover, it seems that 9.2.4 is broken on macOS 13 running on apple silicon (cf. issue) and fix is available in 9.2.5. I discovered that yesterday when updated my machine.

Compiling hls locally works for me; however, your mileage may vary, cf. #3345.

[prikhi]

I can get everything but tactics & haddock-comment plugins building with these stack.yaml changes:

diff --git a/stack.yaml b/stack.yaml
index b9244827..f530dafb 100644
--- a/stack.yaml
+++ b/stack.yaml
@@ -1,4 +1,4 @@
-resolver: nightly-2022-08-15
+resolver: lts-20.2
 
 packages:
 - .
@@ -13,17 +13,17 @@ packages:
 - ./plugins/hls-cabal-fmt-plugin
 - ./plugins/hls-call-hierarchy-plugin
 - ./plugins/hls-class-plugin
-# - ./plugins/hls-haddock-comments-plugin
+- ./plugins/hls-haddock-comments-plugin
 - ./plugins/hls-eval-plugin
 - ./plugins/hls-explicit-imports-plugin
 - ./plugins/hls-qualify-imported-names-plugin
 - ./plugins/hls-refine-imports-plugin
 - ./plugins/hls-hlint-plugin
 - ./plugins/hls-rename-plugin
-# - ./plugins/hls-retrie-plugin
-# - ./plugins/hls-splice-plugin
-# - ./plugins/hls-tactics-plugin
+- ./plugins/hls-retrie-plugin
+- ./plugins/hls-splice-plugin
+- ./plugins/hls-tactics-plugin
 #- ./plugins/hls-brittany-plugin
 - ./plugins/hls-stylish-haskell-plugin
 - ./plugins/hls-floskell-plugin
 - ./plugins/hls-fourmolu-plugin
@@ -52,6 +52,7 @@ extra-deps:
 - lsp-types-1.6.0.0
 - lsp-test-0.14.1.0
 - hie-bios-0.11.0
 
 # currently needed for ghcide>extra, etc.
 allow-newer: true
@@ -74,8 +75,8 @@ flags:
     ignore-plugins-ghc-bounds: true
     brittany: false
     haddockComments: false
-    retrie: false
-    splice: false
+    retrie: true
+    splice: true
     tactic: false
 
   retrie:

like so:

stack install haskell-language-server
mv ~/.local/bin/haskell-language-server ~/.local/bin/haskell-language-server-9.2.5 

Here are the build failures:

hls-haddock-comments-plugin> [1 of 3] Compiling Ide.Plugin.HaddockComments.Prelude
hls-haddock-comments-plugin> 
hls-haddock-comments-plugin> /home/prikhi/code/github/haskell-language-server/plugins/hls-haddock-comments-plugin/src/Ide/Plugin/HaddockComments/Prelude.hs:8:51: error:
hls-haddock-comments-plugin>     Module ‘Language.Haskell.GHC.ExactPrint’ does not export ‘AnnKey’
hls-haddock-comments-plugin>   |
hls-haddock-comments-plugin> 8 | import           Language.Haskell.GHC.ExactPrint (AnnKey, Annotation)
hls-haddock-comments-plugin>   |                                                   ^^^^^^
hls-haddock-comments-plugin> 
hls-haddock-comments-plugin> /home/prikhi/code/github/haskell-language-server/plugins/hls-haddock-comments-plugin/src/Ide/Plugin/HaddockComments/Prelude.hs:8:59: error:
hls-haddock-comments-plugin>     Module
hls-haddock-comments-plugin>     ‘Language.Haskell.GHC.ExactPrint’
hls-haddock-comments-plugin>     does not export
hls-haddock-comments-plugin>     ‘Annotation’
hls-haddock-comments-plugin>   |
hls-haddock-comments-plugin> 8 | import           Language.Haskell.GHC.ExactPrint (AnnKey, Annotation)
hls-haddock-comments-plugin>   |  

hls-tactics-plugin         > /home/prikhi/code/github/haskell-language-server/plugins/hls-tactics-plugin/old/src/Wingman/StaticPlugin.hs:34:16: error:
hls-tactics-plugin         >     Not in scope: ‘staticPlugins’          
hls-tactics-plugin         >     Perhaps you meant one of these:        
hls-tactics-plugin         >       ‘staticPlugin’ (line 25),            
hls-tactics-plugin         >       data constructor ‘StaticPlugin’ (imported from Development.IDE.GHC.Compat)
hls-tactics-plugin         >    |                                       
hls-tactics-plugin         > 34 |              , staticPlugins = staticPlugins df <> [metaprogrammingPlugin]
hls-tactics-plugin         >    |

[peterbecich]

Related issue

ghcup installs HLS incompatible with the compiler
haskell/ghcup-hs#438

[michaelpj]

1.9.0.0 supports 9.2.5