Skip to content

completion suggestions from all modules #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shmish111 opened this issue Aug 20, 2020 · 6 comments
Closed

completion suggestions from all modules #340

shmish111 opened this issue Aug 20, 2020 · 6 comments

Comments

@shmish111
Copy link

It seems completion items only come from the current file, I would like to see suggestions based on all exposed modules including from dependencies that are in my cabal file. After playing with HLS for a while and coming from purescript I would say this is the biggest missing feature for me personally.

@konn
Copy link
Collaborator

konn commented Sep 22, 2020

+1 for it! IIRC, TypeScript Language Server also provides such a feature, provides a symbol completion not only for local and imported modules, but also for all the modules in package dependency and adds missing imports automatically.
Since the size of dependency can tremendously slow down the generation of completion candidate, it might make sense to generate candidates somewhat lazily, or just provide a configuration option to enable/disable such an aggressive completion.

@shmish111
Copy link
Author

I don't think a list of exposed symbols would ever be that big, it could be indexed on startup possibly. If you wanted to include transitive dependencies that need to be exposed in the cabal file (which would be cool) it might be a bit big I guess.

@jneira
Copy link
Member

jneira commented Mar 2, 2021

I wonder if this could be feasible using the new hiedb

@mmgeorge
Copy link

mmgeorge commented Jun 3, 2021

+1. Really liking HLS so far, but agree that suggesting outside of the current file would be great.

@berberman
Copy link
Collaborator

This was discussed in #1327 as well

@jneira
Copy link
Member

jneira commented Jun 4, 2021

@shmish111 @mmgeorge it seems #1327 has some interesting discussion about that so i am gonna close this one, you can track the progress in that issue. Thanks!

@jneira jneira closed this as completed Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants