From b520a708425a4a45fc1ab754b0b0732ef0a1f6ad Mon Sep 17 00:00:00 2001 From: Michael Peyton Jones Date: Fri, 21 Jan 2022 11:07:41 +0000 Subject: [PATCH 1/7] Add initial CODEOWNERS file As discussed in https://github.com/haskell/haskell-language-server/discussions/2588. --- CODEOWNERS | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 CODEOWNERS diff --git a/CODEOWNERS b/CODEOWNERS new file mode 100644 index 0000000000..c2fb5fae58 --- /dev/null +++ b/CODEOWNERS @@ -0,0 +1,36 @@ +# Core +/ghcide @pepeiborra +/hls-graph @pepeiborra + +# Plugins +/plugins/hls-alternate-number-format-plugin @drsooch +/plugins/hls-brittany-plugin @fendor +/plugins/hls-call-hierarchy-plugin @July541 +/plugins/hls-class-plugin @Ailrun +/plugins/hls-eval-plugin @pepeiborra +/plugins/hls-explicit-imports-plugin @pepeiborra +/plugins/hls-floskell-plugin @alanz @Ailrun +/plugins/hls-fourmolu-plugin @georgefst +/plugins/hls-haddock-comments-plugin @berberman +/plugins/hls-hlint-plugin @jneira +/plugins/hls-module-name-plugin @tittoassini +/plugins/hls-ormolu-plugin @alanz +/plugins/hls-pragmas-plugin @berberman @Ailrun +/plugins/hls-qualify-imported-names-plugin @eddiemundo +/plugins/hls-refine-imports-plugin @rayshih +/plugins/hls-rename-plugin @OliverMadine +/plugins/hls-retrie-plugin @pepeiborra +/plugins/hls-splice-plugin @konn +/plugins/hls-stylish-haskell-plugin @Ailrun +/plugins/hls-tactics-plugin @isovector + +# Benchmarking +/shake-bench @pepeiborra + +# CI +/.circleci @jneira @Anton-Latukha +/.githhub @jneira @Anton-Latukha +/.gitlab @jneira @hasufell + +# Other +/hie-compat @wz1000 From e6e1455d7a5bfdcab0d2c5e3fa67472da26bd2e0 Mon Sep 17 00:00:00 2001 From: Michael Peyton Jones Date: Fri, 21 Jan 2022 14:10:10 +0000 Subject: [PATCH 2/7] Add a few more --- CODEOWNERS | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index c2fb5fae58..368c505986 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,6 +1,10 @@ # Core /ghcide @pepeiborra +/ghcide/session-loader @pepeiborra @fendor /hls-graph @pepeiborra +/hls-plugin-api @jneira @berberman +/hls-test-utils @jneira +/hie-compat @wz1000 # Plugins /plugins/hls-alternate-number-format-plugin @drsooch @@ -27,10 +31,14 @@ # Benchmarking /shake-bench @pepeiborra +# Docs +/docs @michaelpj @jneira + # CI /.circleci @jneira @Anton-Latukha /.githhub @jneira @Anton-Latukha /.gitlab @jneira @hasufell -# Other -/hie-compat @wz1000 +# Build +*.nix @berberman @michaelpj +*.project @jneira From c73f5f1f74e043d3052d9a5ed049a3e26e1c1ef3 Mon Sep 17 00:00:00 2001 From: Michael Peyton Jones Date: Fri, 21 Jan 2022 15:44:16 +0000 Subject: [PATCH 3/7] Update CODEOWNERS Co-authored-by: Pepe Iborra --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 368c505986..31d73cf4ed 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -11,7 +11,7 @@ /plugins/hls-brittany-plugin @fendor /plugins/hls-call-hierarchy-plugin @July541 /plugins/hls-class-plugin @Ailrun -/plugins/hls-eval-plugin @pepeiborra +/plugins/hls-eval-plugin @tittoassini /plugins/hls-explicit-imports-plugin @pepeiborra /plugins/hls-floskell-plugin @alanz @Ailrun /plugins/hls-fourmolu-plugin @georgefst From 6b43bceee3551d9257c059ec0ba85d80ab6f1909 Mon Sep 17 00:00:00 2001 From: Michael Peyton Jones Date: Sat, 22 Jan 2022 11:26:07 +0000 Subject: [PATCH 4/7] Apply suggestions from code review Co-authored-by: J. S. Co-authored-by: Junyoung "Clare" Jang --- CODEOWNERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 31d73cf4ed..e28a7f9876 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -16,10 +16,10 @@ /plugins/hls-floskell-plugin @alanz @Ailrun /plugins/hls-fourmolu-plugin @georgefst /plugins/hls-haddock-comments-plugin @berberman -/plugins/hls-hlint-plugin @jneira +/plugins/hls-hlint-plugin @jneira @eddiemundo /plugins/hls-module-name-plugin @tittoassini /plugins/hls-ormolu-plugin @alanz -/plugins/hls-pragmas-plugin @berberman @Ailrun +/plugins/hls-pragmas-plugin @berberman @Ailrun @eddiemundo /plugins/hls-qualify-imported-names-plugin @eddiemundo /plugins/hls-refine-imports-plugin @rayshih /plugins/hls-rename-plugin @OliverMadine @@ -36,7 +36,7 @@ # CI /.circleci @jneira @Anton-Latukha -/.githhub @jneira @Anton-Latukha +/.github @jneira @Anton-Latukha @Ailrun /.gitlab @jneira @hasufell # Build From f3c70d0afc06285b1528111bd5d03c9da5440215 Mon Sep 17 00:00:00 2001 From: Michael Peyton Jones Date: Mon, 24 Jan 2022 14:48:59 +0000 Subject: [PATCH 5/7] Update CODEOWNERS Co-authored-by: Javier Neira --- CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/CODEOWNERS b/CODEOWNERS index e28a7f9876..85248f5b4f 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -24,6 +24,7 @@ /plugins/hls-refine-imports-plugin @rayshih /plugins/hls-rename-plugin @OliverMadine /plugins/hls-retrie-plugin @pepeiborra +/plugins/hls-selection-range-plugin @kokobd /plugins/hls-splice-plugin @konn /plugins/hls-stylish-haskell-plugin @Ailrun /plugins/hls-tactics-plugin @isovector From 9597e5b4ecbf2a51fb22e03eff42bb34f3b79353 Mon Sep 17 00:00:00 2001 From: Michael Peyton Jones Date: Mon, 24 Jan 2022 14:49:41 +0000 Subject: [PATCH 6/7] Add guibou for Nix --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 85248f5b4f..320e79140f 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -41,5 +41,5 @@ /.gitlab @jneira @hasufell # Build -*.nix @berberman @michaelpj +*.nix @berberman @michaelpj @guibou *.project @jneira From 76a4237acc0e0f4e6a0cfff18faa4fbf7554a0b9 Mon Sep 17 00:00:00 2001 From: Michael Peyton Jones Date: Sat, 29 Jan 2022 21:05:43 +0000 Subject: [PATCH 7/7] Remove people who haven't responded --- CODEOWNERS | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 320e79140f..1ec968fbb7 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -4,24 +4,24 @@ /hls-graph @pepeiborra /hls-plugin-api @jneira @berberman /hls-test-utils @jneira -/hie-compat @wz1000 +/hie-compat # Plugins /plugins/hls-alternate-number-format-plugin @drsooch /plugins/hls-brittany-plugin @fendor -/plugins/hls-call-hierarchy-plugin @July541 +/plugins/hls-call-hierarchy-plugin /plugins/hls-class-plugin @Ailrun -/plugins/hls-eval-plugin @tittoassini +/plugins/hls-eval-plugin /plugins/hls-explicit-imports-plugin @pepeiborra -/plugins/hls-floskell-plugin @alanz @Ailrun +/plugins/hls-floskell-plugin @Ailrun /plugins/hls-fourmolu-plugin @georgefst /plugins/hls-haddock-comments-plugin @berberman /plugins/hls-hlint-plugin @jneira @eddiemundo -/plugins/hls-module-name-plugin @tittoassini -/plugins/hls-ormolu-plugin @alanz +/plugins/hls-module-name-plugin +/plugins/hls-ormolu-plugin /plugins/hls-pragmas-plugin @berberman @Ailrun @eddiemundo /plugins/hls-qualify-imported-names-plugin @eddiemundo -/plugins/hls-refine-imports-plugin @rayshih +/plugins/hls-refine-imports-plugin /plugins/hls-rename-plugin @OliverMadine /plugins/hls-retrie-plugin @pepeiborra /plugins/hls-selection-range-plugin @kokobd