Skip to content

Use of lspOptions in ToJSON instance of InitializeParams is not right #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thomasjm opened this issue May 15, 2020 · 1 comment
Closed

Use of lspOptions in ToJSON instance of InitializeParams is not right #246

thomasjm opened this issue May 15, 2020 · 1 comment
Labels
type: bug

Comments

@thomasjm
Copy link
Collaborator

The default lspOptions have omitNothingFields = True. This causes the _processId field of InitializeParams to get omitted when Nothing, in violation of the LSP spec which says its type should be processId: number | null;. It appears the same applies to _rootUri within this type as well.

https://github.com/alanz/haskell-lsp/blob/2ff11293fc55cb59a095918d4193a748bb78078f/haskell-lsp-types/src/Language/Haskell/LSP/Types/DataTypesJSON.hs#L133

I found that the language server jedi-language-server chokes on this.
@thomasjm thomasjm changed the title Use of lspOptions to ToJSON instance of InitializeParams is not right Use of lspOptions in ToJSON instance of InitializeParams is not right May 15, 2020
@thomasjm thomasjm mentioned this issue Dec 17, 2020
Closed
@thomasjm
Copy link
Collaborator Author

Closing in favor of #268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomasjm @lukel97