Skip to content

textDocument/selectionRange uses STextDocumentFoldingRange #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kokobd opened this issue Jan 3, 2022 · 2 comments · Fixed by #388
Closed

textDocument/selectionRange uses STextDocumentFoldingRange #387

kokobd opened this issue Jan 3, 2022 · 2 comments · Fixed by #388
Labels
component: lsp-types type: bug

Comments

@kokobd
Copy link
Collaborator

kokobd commented Jan 3, 2022

While trying to implement haskell/haskell-language-server#212, I notice that in lsp-types, textDocument/selectionRange points to STextDocumentFoldingRange.

lsp/lsp-types/src/Language/LSP/Types/Method.hs

Lines 322 to 323 in 08e8a72

parseJSON (A.String "textDocument/foldingRange") = pure $ SomeClientMethod STextDocumentFoldingRange
parseJSON (A.String "textDocument/selectionRange") = pure $ SomeClientMethod STextDocumentFoldingRange

Is this a typo?
@jneira
Copy link
Member

jneira commented Jan 3, 2022

ugh, thanks for the bug report, i think it will not be difficult to fix, could you have the chance of provide a patch?

@kokobd kokobd mentioned this issue Jan 3, 2022
Merged
@kokobd
Copy link
Collaborator Author

kokobd commented Jan 3, 2022

Okay, PR submitted.

@mergify mergify bot closed this as completed in #388 Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: lsp-types type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix textDocument/selectionRange's method kokobd/lsp
2 participants
@jneira @kokobd