mtd: sst25l: Warn about failure to unregister mtd device

Uwe Kleine-König · miquelraynal · commit b4a0de29f083 · 2021-12-03T14:27:19.000+01:00
mtd_device_unregister() shouldn't fail. Wail loudly if it does anyhow. This matches how other drivers (e.g. nand/raw/nandsim.c) use mtd_device_unregister(). By returning 0 in the spi remove callback a generic error message by the spi framework (and nothing else) is suppressed. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20211108093153.63792-4-u.kleine-koenig@pengutronix.de
diff --git a/drivers/mtd/devices/sst25l.c b/drivers/mtd/devices/sst25l.c
@@ -402,7 +402,9 @@ static int sst25l_remove(struct spi_device *spi)
 {
 	struct sst25l_flash *flash = spi_get_drvdata(spi);
 
-	return mtd_device_unregister(&flash->mtd);
+	WARN_ON(mtd_device_unregister(&flash->mtd));
+
+	return 0;
 }
 
 static struct spi_driver sst25l_driver = {

Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,9 @@ static int sst25l_remove(struct spi_device *spi)`
`402`	`402`	`{`
`403`	`403`	`struct sst25l_flash *flash = spi_get_drvdata(spi);`
`404`	`404`
`405`		`- return mtd_device_unregister(&flash->mtd);`
	`405`	`+ WARN_ON(mtd_device_unregister(&flash->mtd));`
	`406`	`+`
	`407`	`+ return 0;`
`406`	`408`	`}`
`407`	`409`
`408`	`410`	`static struct spi_driver sst25l_driver = {`