Skip to content

(protobuf) Should highlight multiline comments as comments #2561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Paxa opened this issue May 16, 2020 · 4 comments · Fixed by #2597
Closed

(protobuf) Should highlight multiline comments as comments #2561

Paxa opened this issue May 16, 2020 · 4 comments · Fixed by #2597
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language

Comments

@Paxa
Copy link
Contributor

Paxa commented May 16, 2020

protobuf supports comments like /* bla bla */, but they are not highlighted

Screen Shot 2020-05-17 at 02 20 13

https://developers.google.com/protocol-buffers/docs/proto3#adding-comments
@Paxa Paxa added bug help welcome Could use help from community language labels May 16, 2020
@joshgoebel
Copy link
Member

@Paxa Should be a simple one line patch, you up for making a PR?

@joshgoebel joshgoebel added the good first issue Should be easier for first time contributors label May 17, 2020
@joshgoebel joshgoebel changed the title (protobuf) Multiline comments (protobuf) Should highlight multiline comments as comments May 17, 2020
@joshgoebel
Copy link
Member

Ping. @Paxa

@Paxa
Copy link
Contributor Author

Paxa commented Jun 8, 2020

I can try

@joshgoebel
Copy link
Member

Awesome. Looking forward to seeing!

@Paxa Paxa mentioned this issue Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support multiline comments in protobuf Paxa/highlight.js
2 participants
@joshgoebel @Paxa