Skip to content

Commit 2ef3fa8

Browse files
committed
temporarily disable fboxes for sessions
the way fboxes works has issues for the sessions implementation, in particular tthe session finalize approach. what happens without this temporary fix is that if there is not some fully shcnronizing call prior to calling session_finalize, there are cases where a process may be probing its fast mailboxes for processes that are tearing down theses fboxes. That results in segfauls and sigbus problems. The fast box mechanism will need to be supplemented with some kind of shutdown mechanism that will tell the owner of the fboxes when its okay to actually tear them down. IN the interest of making progress using the sessions prototype with applications, shut down the fbox process for the prototype and return to coming up with a real fix at a later date. relates to #3 Signed-off-by: Howard Pritchard <[email protected]>
1 parent cad26bd commit 2ef3fa8

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

opal/mca/btl/vader/btl_vader_fifo.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,9 @@ static inline bool vader_fifo_write_ep (mca_btl_vader_hdr_t *hdr, struct mca_btl
203203
opal_atomic_wmb ();
204204
return mca_btl_vader_fbox_sendi (ep, 0xfe, &rhdr, sizeof (rhdr), NULL, 0);
205205
}
206+
#if 0
206207
mca_btl_vader_try_fbox_setup (ep, hdr);
208+
#endif
207209
hdr->next = VADER_FIFO_FREE;
208210
vader_fifo_write (ep->fifo, rhdr);
209211

0 commit comments

Comments
 (0)