Skip to content

Commit 7815f84

Browse files
committed
[android] do not build the builtin float overlay for android (NDK's clang module map doesn't have it)
1 parent 7a5a0aa commit 7815f84

File tree

2 files changed

+18
-13
lines changed

2 files changed

+18
-13
lines changed
Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,19 @@
1-
add_swift_target_library(swift_Builtin_float
2-
${SWIFT_STDLIB_LIBRARY_BUILD_TYPES}
3-
IS_SDK_OVERLAY
1+
if(NOT DEFINED SWIFT_BUILD_CLANG_OVERLAYS_SKIP_BUILTIN_FLOAT OR NOT SWIFT_BUILD_CLANG_OVERLAYS_SKIP_BUILTIN_FLOAT)
2+
add_swift_target_library(swift_Builtin_float
3+
${SWIFT_STDLIB_LIBRARY_BUILD_TYPES}
4+
IS_SDK_OVERLAY
45

5-
GYB_SOURCES
6-
float.swift.gyb
6+
GYB_SOURCES
7+
float.swift.gyb
78

8-
SWIFT_COMPILE_FLAGS
9-
${SWIFT_RUNTIME_SWIFT_COMPILE_FLAGS}
10-
${SWIFT_STANDARD_LIBRARY_SWIFT_FLAGS}
11-
-Xfrontend -previous-module-installname-map-file -Xfrontend "${SWIFT_SOURCE_DIR}/stdlib/linker-support/previous-module-installname.json"
9+
SWIFT_COMPILE_FLAGS
10+
${SWIFT_RUNTIME_SWIFT_COMPILE_FLAGS}
11+
${SWIFT_STANDARD_LIBRARY_SWIFT_FLAGS}
12+
-Xfrontend -previous-module-installname-map-file -Xfrontend "${SWIFT_SOURCE_DIR}/stdlib/linker-support/previous-module-installname.json"
1213

13-
LINK_FLAGS
14-
${SWIFT_RUNTIME_SWIFT_LINK_FLAGS}
14+
LINK_FLAGS
15+
${SWIFT_RUNTIME_SWIFT_LINK_FLAGS}
1516

16-
INSTALL_IN_COMPONENT stdlib
17-
MACCATALYST_BUILD_FLAVOR zippered)
17+
INSTALL_IN_COMPONENT stdlib
18+
MACCATALYST_BUILD_FLAVOR zippered)
19+
endif()

utils/build.ps1

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -832,6 +832,9 @@ function Build-CMakeProject {
832832
TryAdd-KeyValue $Defines SWIFT_ANDROID_NDK_PATH "$androidNDKPath"
833833
TryAdd-KeyValue $Defines CMAKE_C_COMPILER_WORKS YES
834834
TryAdd-KeyValue $Defines CMAKE_CXX_COMPILER_WORKS YES
835+
# The current Android NDK ships with Clang 17,
836+
# which doesn't provide the _Builtin_float module.
837+
TryAdd-KeyValue $Defines SWIFT_BUILD_CLANG_OVERLAYS_SKIP_BUILTIN_FLOAT YES
835838
}
836839

837840
TryAdd-KeyValue $Defines CMAKE_BUILD_TYPE Release

0 commit comments

Comments
 (0)