Skip to content

Commit c0ff17d

Browse files
committed
refactor: requested changes
1 parent 4b0e15f commit c0ff17d

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

projects/components/src/page-time-range/page-time-range.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@ import { PopoverRelativePositionLocation } from '../popover/popover';
88
selector: 'ht-page-time-range',
99
template: `
1010
<ht-time-range
11-
[dropdownLocation]="this.dropdownLocation"
11+
[dropdownLocationPreference]="this.dropdownLocationPreference"
1212
(timeRangeSelected)="this.onTimeRangeSelected($event)"
1313
></ht-time-range>
1414
`,
1515
changeDetection: ChangeDetectionStrategy.OnPush
1616
})
1717
export class PageTimeRangeComponent {
18-
public readonly dropdownLocation: PopoverRelativePositionLocation[] = [
18+
public readonly dropdownLocationPreference: PopoverRelativePositionLocation[] = [
1919
PopoverRelativePositionLocation.BelowRightAligned
2020
];
2121

projects/components/src/time-range/time-range.component.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { PopoverRef } from '../popover/popover-ref';
2525
<ht-popover
2626
(popoverOpen)="this.onPopoverOpen($event)"
2727
[closeOnNavigate]="false"
28-
[locationPreferences]="this.dropdownLocation"
28+
[locationPreferences]="this.dropdownLocationPreference"
2929
>
3030
<ht-popover-trigger>
3131
<div class="trigger">
@@ -73,9 +73,11 @@ import { PopoverRef } from '../popover/popover-ref';
7373
})
7474
export class TimeRangeComponent {
7575
@Input()
76-
public dropdownLocation: PopoverRelativePositionLocation[] = [
76+
public dropdownLocationPreference: PopoverRelativePositionLocation[] = [
7777
PopoverRelativePositionLocation.BelowLeftAligned,
78-
PopoverRelativePositionLocation.BelowRightAligned
78+
PopoverRelativePositionLocation.BelowRightAligned,
79+
PopoverRelativePositionLocation.AboveLeftAligned,
80+
PopoverRelativePositionLocation.AboveRightAligned
7981
];
8082

8183
public timeRange$: Observable<TimeRange> = this.timeRangeService.getTimeRangeAndChanges();

0 commit comments

Comments
 (0)