Skip to content

Commit 853e233

Browse files
committed
CI: Use towncrier build explicitly
Without any argument towncrier defaults to `build`. But towncrier added a `--version` argument to just print the towncrier version. NumPy relies on passing `--version` which collides. Even if towncrier might revert the change, using `towncrier build` explicitly just doesn't hurt. Closes numpygh-18788
1 parent c7282cf commit 853e233

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
. venv/bin/activate
4343
pip install git+https://github.com/hawkowl/towncrier.git@master
4444
VERSION=$(python -c "import setup; print(setup.VERSION)")
45-
towncrier --version $VERSION --yes
45+
towncrier build --version $VERSION --yes
4646
./tools/ci/test_all_newsfragments_used.py
4747
4848
- run:

doc/release/upcoming_changes/README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ and double-backticks for code.
5050
If you are unsure what pull request type to use, don't hesitate to ask in your
5151
PR.
5252

53-
You can install ``towncrier`` and run ``towncrier --draft --version 1.18``
53+
You can install ``towncrier`` and run ``towncrier build --draft --version 1.18``
5454
if you want to get a preview of how your change will look in the final release
5555
notes.
5656

tools/ci/test_all_newsfragments_used.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@
1212

1313
if fragments:
1414
print("The following files were not found by towncrier:")
15-
print(" " + " \n".join(fragments))
15+
print(" " + "\n ".join(fragments))
1616
sys.exit(1)

0 commit comments

Comments
 (0)