Skip to content

Commit 918e489

Browse files
committed
#55 Clean up example dependencies
1 parent 9b4db0a commit 918e489

File tree

2 files changed

+22
-18
lines changed

2 files changed

+22
-18
lines changed

pom.xml

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
2+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
34
<modelVersion>4.0.0</modelVersion>
45

56
<groupId>com.iluwatar</groupId>
@@ -16,6 +17,7 @@
1617
<compiler.version>3.0</compiler.version>
1718
<coveralls.version>3.1.0</coveralls.version>
1819
<jacoco.version>0.7.2.201409121644</jacoco.version>
20+
<commons-dbcp.version>1.4</commons-dbcp.version>
1921
</properties>
2022
<modules>
2123
<module>abstract-factory</module>
@@ -68,12 +70,12 @@
6870
<module>dependency-injection</module>
6971
<module>naked-objects</module>
7072
<module>front-controller</module>
71-
<module>repository</module>
72-
</modules>
73+
<module>repository</module>
74+
</modules>
7375

7476
<dependencyManagement>
7577
<dependencies>
76-
<dependency>
78+
<dependency>
7779
<groupId>org.hibernate</groupId>
7880
<artifactId>hibernate-core</artifactId>
7981
<version>${hibernate.version}</version>
@@ -93,6 +95,11 @@
9395
<artifactId>h2</artifactId>
9496
<version>${h2.version}</version>
9597
</dependency>
98+
<dependency>
99+
<groupId>commons-dbcp</groupId>
100+
<artifactId>commons-dbcp</artifactId>
101+
<version>${commons-dbcp.version}</version>
102+
</dependency>
96103
<dependency>
97104
<groupId>junit</groupId>
98105
<artifactId>junit</artifactId>
@@ -130,7 +137,7 @@
130137
</goals>
131138
</pluginExecutionFilter>
132139
<action>
133-
<ignore/>
140+
<ignore />
134141
</action>
135142
</pluginExecution>
136143
</pluginExecutions>
@@ -163,8 +170,11 @@
163170
<groupId>org.jacoco</groupId>
164171
<artifactId>jacoco-maven-plugin</artifactId>
165172
<version>${jacoco.version}</version>
166-
<!-- The following exclude configuration was added because error occurred when executing "mvn clean test jacoco:report coveralls:report" -->
167-
<!-- [ERROR] Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:3.1.0:report (default-cli) on project java-design-patterns: I/O operation failed: No source found for domainapp/dom/modules/simple/QSimpleObject.java -> [Help 1] -->
173+
<!-- The following exclude configuration was added because error occurred
174+
when executing "mvn clean test jacoco:report coveralls:report" -->
175+
<!-- [ERROR] Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:3.1.0:report
176+
(default-cli) on project java-design-patterns: I/O operation failed: No source
177+
found for domainapp/dom/modules/simple/QSimpleObject.java -> [Help 1] -->
168178
<configuration>
169179
<excludes>
170180
<exclude>domainapp/dom/modules/simple/QSimpleObject.class</exclude>

repository/pom.xml

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,6 @@
1010
</parent>
1111
<artifactId>repository</artifactId>
1212
<dependencies>
13-
<dependency>
14-
<groupId>junit</groupId>
15-
<artifactId>junit</artifactId>
16-
<scope>test</scope>
17-
</dependency>
1813
<dependency>
1914
<groupId>org.springframework.data</groupId>
2015
<artifactId>spring-data-jpa</artifactId>
@@ -23,19 +18,18 @@
2318
<groupId>org.hibernate</groupId>
2419
<artifactId>hibernate-entitymanager</artifactId>
2520
</dependency>
26-
<dependency>
27-
<groupId>org.postgresql</groupId>
28-
<artifactId>postgresql</artifactId>
29-
<version>9.4-1200-jdbc4</version>
30-
</dependency>
3121
<dependency>
3222
<groupId>commons-dbcp</groupId>
3323
<artifactId>commons-dbcp</artifactId>
34-
<version>1.4</version>
3524
</dependency>
3625
<dependency>
3726
<groupId>com.h2database</groupId>
3827
<artifactId>h2</artifactId>
3928
</dependency>
29+
<dependency>
30+
<groupId>junit</groupId>
31+
<artifactId>junit</artifactId>
32+
<scope>test</scope>
33+
</dependency>
4034
</dependencies>
4135
</project>

0 commit comments

Comments
 (0)