Skip to content

Remove HTML-Proofer from build #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iluwatar opened this issue Nov 20, 2016 · 4 comments
Closed

Remove HTML-Proofer from build #522

iluwatar opened this issue Nov 20, 2016 · 4 comments

Comments

@iluwatar
Copy link
Owner

There's a module called HTML-Proofer doing link analysis each time gh-pages branch is built. Lately it has been failing for various reasons (e.g. https://travis-ci.org/iluwatar/java-design-patterns/builds/177235379) and I would suggest that it would be removed from the build altogether.

@markusmo3
Copy link
Contributor

Heya there,

im against this change, but also sorry i didnt pay a lot attention to those build failures earlier.

The HTML-Proofer uncovers important problems, like absolute links in the newest blog page:

![Hexagonal Architecture]({{ site.url }}{{ site.baseurl }}/assets/hexagonal-architecture.png)

This will fail, on purpose and in my opinion for good, because every build of the website would depend on our main webpage jdp.com instead of on itself. Absolute links for linking inside our own website arent good. using site.baseurl is enough in this case.

And the sonarqube issue seems to be an issue with certificates and/or ssl connection. Im working on that.

@iluwatar
Copy link
Owner Author

Ok, we can keep it if you insist but then we have to fix the current issues and react quickly when it reports errors. Also, I have modified the build sequence in de7abf9 to run the S3 deployment despite of HTML-Proofer errors. I don't know if this should be reverted.

@markusmo3
Copy link
Contributor

markusmo3 commented Nov 21, 2016

The newest build is successful again:
https://travis-ci.org/iluwatar/java-design-patterns/builds/177775274

And im fine with the s3 deployment going through even if the HTML-Proofer fails. It's just a tool for reinforcing good valid websites, but if rapid prototyping is needed it can be a hassle. This will most likely hide some issues like those internal links but thats okay, i guess ^^

EDIT: also fixed the blog links:
5bd2345

@iluwatar
Copy link
Owner Author

Good enough for me. Thanks for fixing this @markusmo3 👍

@iluwatar iluwatar added this to the 1.14.0 milestone Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants