Merge pull request #48 from WTW-IM/fix-async-unmount

stevematney · web-flow · commit 4901a9f3ba40 · 2023-08-15T14:41:56.000-06:00
diff --git a/src/ReactHTMLElement.ts b/src/ReactHTMLElement.ts
@@ -82,7 +82,8 @@ class ReactHTMLElement extends HTMLElement {
   disconnectedCallback(): void {
     if (!this._mountPoint) return;
 
-    this._root?.unmount();
+    // setTimeout to avoid synchronous unmount
+    setTimeout(() => this._root?.unmount(), 0);
   }
 
   constructor(template = '<div></div>', mountSelector = 'div') {

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,8 @@ class ReactHTMLElement extends HTMLElement {`
`82`	`82`	`disconnectedCallback(): void {`
`83`	`83`	`if (!this._mountPoint) return;`
`84`	`84`
`85`		`- this._root?.unmount();`
	`85`	`+ // setTimeout to avoid synchronous unmount`
	`86`	`+ setTimeout(() => this._root?.unmount(), 0);`
`86`	`87`	`}`
`87`	`88`
`88`	`89`	`constructor(template = '<div></div>', mountSelector = 'div') {`