From 77aa7ed1a53fc609b66600092023fa17707bcafd Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Thu, 14 Jun 2012 01:47:43 +0300 Subject: [PATCH] Parsing a string into a Date is expensive and not needed for the 304 Not Modified caching mechanism --- lightnode.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lightnode.js b/lightnode.js index dc05c49..4a3aaae 100644 --- a/lightnode.js +++ b/lightnode.js @@ -357,11 +357,12 @@ exports.FileServer = type(exports.HttpServer, function() { if (ext in mimeTypes) headers['content-type'] = mimeTypes[ext] - headers['last-modified'] = new(Date)(file.header.mtime).toUTCString() + var dateModified = new(Date)(file.header.mtime).toUTCString() + headers['last-modified'] = dateModified headers['transfer-encoding'] = 'chunked' headers['server'] = 'lightnode' - if (Date.parse(file.header.mtime) <= Date.parse(req.headers['if-modified-since'])) { + if (dateModified === req.headers['if-modified-since']) { resp.writeHead(304, headers) resp.end() return