Skip to content

Add Windows build and tests to required hydra job. #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 16, 2020
Merged

Add Windows build and tests to required hydra job. #669

merged 5 commits into from
Mar 16, 2020

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented Mar 12, 2020

No description provided.

@jbgi jbgi added bug Something isn't working WIP Work In Progress (cannot be merged yet) labels Mar 12, 2020
@jbgi jbgi force-pushed the require-w64-tests branch 2 times, most recently from c1bc37c to f8c9759 Compare March 12, 2020 13:07
@jbgi jbgi added bug Something isn't working WIP Work In Progress (cannot be merged yet) and removed WIP Work In Progress (cannot be merged yet) bug Something isn't working labels Mar 12, 2020
@jbgi jbgi changed the title Add Windows tests to required hydra job. Add Windows build and tests to required hydra job. Mar 12, 2020
@jbgi jbgi requested review from dcoutts and coot March 12, 2020 15:13
@coot coot mentioned this pull request Mar 12, 2020
Closed
jbgi
jbgi commented Mar 13, 2020
View reviewed changes
jbgi and others added 4 commits March 16, 2020 17:48
@jbgi @dcoutts
Add Windows tests to required hydra job.
f8b71d3
@jbgi @dcoutts
Update iohk-nix and haskell.nix
5d95f66
@jbgi @dcoutts
Require job windows cross build of cardano-node to pass
6e2b0bf 
 also disable some non-sensical cross builds
@cleverca22 @dcoutts
fix hydra eval
b71eeb6 
the nixos tests where using cardano-config at eval time
as a result, ANY build error in cardano-config, would block hydra from
reporting ALL errors for the whole repo
@dcoutts dcoutts force-pushed the require-w64-tests branch from c2cccef to b71eeb6 Compare March 16, 2020 17:53
dcoutts
dcoutts approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not really qualified to review the nix changes.

I see that Windows is now listed in the CI job constituents though.

@dcoutts dcoutts mentioned this pull request Mar 16, 2020
Merged
5 tasks
@dcoutts dcoutts added byron Required for a Byron mainnet: replace the old core nodes with cardano-node. priority high issues/PRs that MUST be addressed. The release can't happen without this; and removed WIP Work In Progress (cannot be merged yet) bug Something isn't working labels Mar 16, 2020
@disassembler
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 16, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 8de7d3b into master Mar 16, 2020
@iohk-bors iohk-bors bot deleted the require-w64-tests branch March 16, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

@cleverca22 cleverca22 cleverca22 approved these changes

@dcoutts dcoutts dcoutts approved these changes

@johnalotoski johnalotoski johnalotoski approved these changes

@coot coot Awaiting requested review from coot

Assignees
No one assigned
Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node. priority high issues/PRs that MUST be addressed. The release can't happen without this;
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbgi @disassembler @cleverca22 @dcoutts @johnalotoski