Skip to content

Add support for "require review from code owners" #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thomasbrezinski opened this issue Oct 4, 2017 · 1 comment · Fixed by #51
Closed

Add support for "require review from code owners" #50

thomasbrezinski opened this issue Oct 4, 2017 · 1 comment · Fixed by #51
Labels
Type: Feature New feature or request

Comments

@thomasbrezinski
Copy link

GitHub added the ability to require reviews from code owners in July. It doesn't look like support for this has made it into terraform-provider-github quite yet.

It seems like a simple update to the PullRequestReviewsEnforcement and PullRequestReviewsEnforcementRequest to handle this additional field.

Terraform Version

Terraform v0.10.7

Affected Resource(s)

github_branch_protection

Terraform Configuration Files

Ideally, this would be supported.

resource "github_branch_protection" "foo_master" {
  repository = "foo"
  branch = "master"

  required_pull_request_reviews {
    require_code_owner_reviews = true
  }
}

References

https://developer.github.com/v3/repos/branches/#get-pull-request-review-enforcement-of-protected-branch

@denniswebb
Copy link
Contributor

I'm working on a PR to support this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants