Skip to content

Commit 08916e3

Browse files
igchorbyrnedj
authored andcommitted
Enable touchValue by default
1 parent 748babd commit 08916e3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

cachelib/cachebench/cache/Cache.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ class Cache {
112112
explicit Cache(const CacheConfig& config,
113113
ChainedItemMovingSync movingSync = {},
114114
std::string cacheDir = "",
115-
bool touchValue = false);
115+
bool touchValue = true);
116116

117117
~Cache();
118118

@@ -439,7 +439,7 @@ class Cache {
439439
std::unique_ptr<ValueTracker> valueTracker_;
440440

441441
// read entire value on find.
442-
bool touchValue_{false};
442+
bool touchValue_{true};
443443

444444
// reading of the nand bytes written for the benchmark if enabled.
445445
const uint64_t nandBytesBegin_{0};

cachelib/cachebench/util/Config.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ struct StressorConfig : public JSONConfig {
206206

207207
// If enabled, each value will be read on find. This is useful for measuring
208208
// performance of value access.
209-
bool touchValue{false};
209+
bool touchValue{true};
210210

211211
uint64_t numOps{0}; // operation per thread
212212
uint64_t numThreads{0}; // number of threads that will run

0 commit comments

Comments
 (0)