ci: update golangi-lint to v1.54.2

mythi · mythi · commit 1c209ab40436 · 2023-09-05T15:37:23.000+03:00
Signed-off-by: Mikko Ylinen &lt;mikko.ylinen@intel.com&gt;
diff --git a/Makefile b/Makefile
@@ -10,7 +10,7 @@ EXTRA_BUILD_ARGS ?= ""
 
 CERT_MANAGER_VERSION ?= v1.12.2
 CONTROLLER_GEN_VERSION ?= v0.13.0
-GOLANGCI_LINT_VERSION ?= v1.53.3
+GOLANGCI_LINT_VERSION ?= v1.54.2
 KIND_VERSION ?= v0.19.0
 GOLICENSES_VERSION ?= v1.6.0
 # Default bundle image tag
diff --git a/pkg/controllers/reconciler_test.go b/pkg/controllers/reconciler_test.go
@@ -60,7 +60,9 @@ func TestUpgrade(test *testing.T) {
 		},
 	}
 
-	for _, t := range tests {
+	for i := range tests {
+		t := tests[i]
+
 		upgrade := UpgradeImages(&t.image, &t.initimage)
 
 		if !(upgrade == t.upgrade && t.image == t.expectedImage && t.initimage == t.expectedInitimage) {

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,9 @@ func TestUpgrade(test *testing.T) {`
`60`	`60`	`},`
`61`	`61`	`}`
`62`	`62`
`63`		`- for _, t := range tests {`
	`63`	`+ for i := range tests {`
	`64`	`+ t := tests[i]`
	`65`	`+`
`64`	`66`	`upgrade := UpgradeImages(&t.image, &t.initimage)`
`65`	`67`
`66`	`68`	`if !(upgrade == t.upgrade && t.image == t.expectedImage && t.initimage == t.expectedInitimage) {`