Skip to content

Commit c3a3561

Browse files
committed
webhooks: stop handling Pod updates
FPGA and SGX webhooks mutate container resources which are immutable. Therefore, stop processing pod updates and act on creation only. Signed-off-by: Mikko Ylinen <[email protected]>
1 parent dc6979f commit c3a3561

File tree

5 files changed

+2
-6
lines changed

5 files changed

+2
-6
lines changed

deployments/fpga_admissionwebhook/webhook/manifests.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ webhooks:
2020
- v1
2121
operations:
2222
- CREATE
23-
- UPDATE
2423
resources:
2524
- pods
2625
sideEffects: None

deployments/operator/webhook/manifests.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ webhooks:
161161
- v1
162162
operations:
163163
- CREATE
164-
- UPDATE
165164
resources:
166165
- pods
167166
sideEffects: None
@@ -182,7 +181,6 @@ webhooks:
182181
- v1
183182
operations:
184183
- CREATE
185-
- UPDATE
186184
resources:
187185
- pods
188186
sideEffects: None

deployments/sgx_admissionwebhook/webhook/manifests.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ webhooks:
2121
- v1
2222
operations:
2323
- CREATE
24-
- UPDATE
2524
resources:
2625
- pods
2726
sideEffects: None

pkg/fpgacontroller/patcher/patchermanager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ func (pm *Manager) GetPodMutator() func(ctx context.Context, req webhook.Admissi
7171
return pm.mutate
7272
}
7373

74-
// +kubebuilder:webhook:verbs=create;update,path=/pods,mutating=true,failurePolicy=Ignore,groups="",resources=pods,versions=v1,name=fpga.mutator.webhooks.intel.com,sideEffects=None,admissionReviewVersions=v1
74+
// +kubebuilder:webhook:verbs=create,path=/pods,mutating=true,failurePolicy=Ignore,groups="",resources=pods,versions=v1,name=fpga.mutator.webhooks.intel.com,sideEffects=None,admissionReviewVersions=v1
7575

7676
func (pm *Manager) mutate(ctx context.Context, req webhook.AdmissionRequest) webhook.AdmissionResponse {
7777
podResource := metav1.GroupVersionResource{Group: "", Version: "v1", Resource: "pods"}

pkg/webhooks/sgx/sgx.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import (
2929

3030
var ErrObjectType = errors.New("invalid runtime object type")
3131

32-
// +kubebuilder:webhook:path=/mutate--v1-pod,mutating=true,failurePolicy=ignore,groups="",resources=pods,verbs=create;update,versions=v1,name=sgx.mutator.webhooks.intel.com,sideEffects=None,admissionReviewVersions=v1,reinvocationPolicy=IfNeeded
32+
// +kubebuilder:webhook:path=/mutate--v1-pod,mutating=true,failurePolicy=ignore,groups="",resources=pods,verbs=create,versions=v1,name=sgx.mutator.webhooks.intel.com,sideEffects=None,admissionReviewVersions=v1,reinvocationPolicy=IfNeeded
3333

3434
// Mutator annotates Pods.
3535
type Mutator struct{}

0 commit comments

Comments
 (0)