Package names passed to source control / server command extensions are missing .pkg extension

[isc-svelury]

Unlike Studio, names of packages selected by users in the explorer view are not passed with the .pkg extension in VS Code. This creates inconsistencies and failures in VS Code. Our current workaround for this is to check if the package has any classes and explicitly add the extension if it does. This will not work if the package has no classes.

Also see: this git-source-control hooks issue

@timleavitt

[isc-bsaviano]

@isc-svelury Do you mean the ObjectScript Explorer or the regular file explorer set up to use isfs? I verified that when clicking on a package node in the ObjectScript Explorer, .PKG is added to the end of the name:

vscode-objectscript/src/commands/studio.ts

Lines 76 to 80 in 421ea58

	} else if (uriOrNode) {
	const node: NodeBase = uriOrNode;
	this.api = new AtelierAPI();
	this.name = node instanceof PackageNode ? node.fullName + ".PKG" : node.fullName;
	} else {

[isc-tleavitt]

@isc-bsaviano good question - this would be the regular file explorer set up to use isfs.