Skip to content

content: Swiper.js migration, slidesPerView value is incorrect #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Sampath-Lokuge opened this issue Apr 30, 2023 · 2 comments · Fixed by #2945
Closed

content: Swiper.js migration, slidesPerView value is incorrect #2944

Sampath-Lokuge opened this issue Apr 30, 2023 · 2 comments · Fixed by #2945
Labels
content Issues related to the contents of the documentation website

Comments

@Sampath-Lokuge
Copy link

Describe the Bug

<ion-slides [options]="{ slidesPerView: true, loop: true }">
  <ion-slide>Slide 1</ion-slide>
  <ion-slide>Slide 3</ion-slide>
  <ion-slide>Slide 3</ion-slide>
</ion-slides>

Ref: https://ionicframework.com/docs/angular/slides#properties

Expected Behavior

<ion-slides [options]="{ slidesPerView: 3, loop: true }">
  <ion-slide>Slide 1</ion-slide>
  <ion-slide>Slide 3</ion-slide>
  <ion-slide>Slide 3</ion-slide>
</ion-slides>

Steps to Reproduce

No boolean for slidesPerView:. i.e. it must be number.

Screenshots

No response

Operating System

No response

Browser

No response

Version

No response

Additional Information

No response
@Sampath-Lokuge Sampath-Lokuge added the triage New issues label Apr 30, 2023
@averyjohnston averyjohnston changed the title bug: ion-slides property issue content: Swiper.js migration, slidesPerView value is incorrect May 1, 2023
@averyjohnston averyjohnston added the content Issues related to the contents of the documentation website label May 1, 2023
@ionitron-bot ionitron-bot bot removed the triage New issues label May 1, 2023
@averyjohnston averyjohnston mentioned this issue May 1, 2023
Merged
@averyjohnston
Copy link
Contributor

Fixed via #2945, thank you!

@Sampath-Lokuge
Copy link
Author

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Issues related to the contents of the documentation website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(Swiper): fix typo in slidesPerView value ionic-team/ionic-docs
2 participants
@Sampath-Lokuge @averyjohnston