From 4026dfa5c44fe1157f5f8db098942cbd4aa5fd97 Mon Sep 17 00:00:00 2001 From: Maria Hutt Date: Fri, 1 Dec 2023 14:23:25 -0800 Subject: [PATCH 1/2] chore(google-tag-manager): switch to Docusaurus preset --- docusaurus.config.js | 8 ++++---- package-lock.json | 12 ------------ package.json | 1 - 3 files changed, 4 insertions(+), 17 deletions(-) diff --git a/docusaurus.config.js b/docusaurus.config.js index 7e982da5587..65811d54014 100644 --- a/docusaurus.config.js +++ b/docusaurus.config.js @@ -60,6 +60,10 @@ module.exports = { }, }, }, + // Will be passed to @docusaurus/plugin-google-tag-manager + googleTagManager: { + containerId: 'GTM-TKMGCBC', + }, // Will be passed to @docusaurus/theme-classic. theme: { customCss: [ @@ -269,9 +273,6 @@ module.exports = { }, ], }, - tagManager: { - trackingID: 'GTM-TKMGCBC', - }, prism: { theme: { plain: {}, styles: [] }, // https://github.com/FormidableLabs/prism-react-renderer/blob/5a1c93592c6475fb230bfcb8a9666b72b331638b/packages/generate-prism-languages/index.ts#L9-L24 @@ -297,7 +298,6 @@ module.exports = { }, }, ], - '@ionic-internal/docusaurus-plugin-tag-manager', function (context, options) { return { name: 'ionic-docs-ads', diff --git a/package-lock.json b/package-lock.json index 546773edcb2..40957bc8d08 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12,7 +12,6 @@ "@docusaurus/mdx-loader": "^2.4.3", "@docusaurus/plugin-client-redirects": "^2.4.3", "@docusaurus/preset-classic": "^2.4.3", - "@ionic-internal/docusaurus-plugin-tag-manager": "^2.0.0", "@ionic-internal/ionic-ds": "^7.0.0", "@mdx-js/react": "^1.6.22", "@prismicio/client": "^6.4.2", @@ -3578,17 +3577,6 @@ "@hapi/hoek": "^9.0.0" } }, - "node_modules/@ionic-internal/docusaurus-plugin-tag-manager": { - "version": "2.0.0", - "license": "MIT", - "engines": { - "node": ">=10.15.1" - }, - "peerDependencies": { - "react": "^16.8.4 || ^17.0.0", - "react-dom": "^16.8.4 || ^17.0.0" - } - }, "node_modules/@ionic-internal/ionic-ds": { "version": "7.0.0", "license": "MIT", diff --git a/package.json b/package.json index 3ae2615f268..6c52c5bc58f 100644 --- a/package.json +++ b/package.json @@ -41,7 +41,6 @@ "@docusaurus/mdx-loader": "^2.4.3", "@docusaurus/plugin-client-redirects": "^2.4.3", "@docusaurus/preset-classic": "^2.4.3", - "@ionic-internal/docusaurus-plugin-tag-manager": "^2.0.0", "@ionic-internal/ionic-ds": "^7.0.0", "@mdx-js/react": "^1.6.22", "@prismicio/client": "^6.4.2", From 109d5742355e3f22fb14d05c49ebb1225c920b19 Mon Sep 17 00:00:00 2001 From: Maria Hutt Date: Fri, 1 Dec 2023 14:24:58 -0800 Subject: [PATCH 2/2] chore(google-tag-manager): add periods --- docusaurus.config.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docusaurus.config.js b/docusaurus.config.js index 65811d54014..301d9525760 100644 --- a/docusaurus.config.js +++ b/docusaurus.config.js @@ -30,7 +30,7 @@ module.exports = { '@docusaurus/preset-classic', /** @type {import('@docusaurus/preset-classic').Options} */ { - // Will be passed to @docusaurus/plugin-content-docs (false to disable) + // Will be passed to @docusaurus/plugin-content-docs (false to disable). docs: { routeBasePath: '/', sidebarPath: require.resolve('./sidebars.js'), @@ -60,7 +60,7 @@ module.exports = { }, }, }, - // Will be passed to @docusaurus/plugin-google-tag-manager + // Will be passed to @docusaurus/plugin-google-tag-manager. googleTagManager: { containerId: 'GTM-TKMGCBC', },