From 6c96011f3b0596bf325fc92bc47eaf74e053f22b Mon Sep 17 00:00:00 2001 From: Brandy Carney <6577830+brandyscarney@users.noreply.github.com> Date: Wed, 18 Dec 2024 19:06:43 -0500 Subject: [PATCH 1/5] docs(action-sheet): update angular to standalone --- .../v7/action-sheet/controller/angular/example_component_ts.md | 2 ++ .../action-sheet/inline/isOpen/angular/example_component_ts.md | 2 ++ .../action-sheet/inline/trigger/angular/example_component_ts.md | 2 ++ .../role-info-on-dismiss/angular/example_component_ts.md | 2 ++ .../theming/css-properties/angular/example_component_ts.md | 2 ++ .../theming/styling/angular/example_component_ts.md | 2 ++ .../v8/action-sheet/controller/angular/example_component_ts.md | 2 ++ .../action-sheet/inline/isOpen/angular/example_component_ts.md | 2 ++ .../action-sheet/inline/trigger/angular/example_component_ts.md | 2 ++ .../role-info-on-dismiss/angular/example_component_ts.md | 2 ++ .../theming/css-properties/angular/example_component_ts.md | 2 ++ .../theming/styling/angular/example_component_ts.md | 2 ++ 12 files changed, 24 insertions(+) diff --git a/static/usage/v7/action-sheet/controller/angular/example_component_ts.md b/static/usage/v7/action-sheet/controller/angular/example_component_ts.md index c7ecc272663..62d15b7039a 100644 --- a/static/usage/v7/action-sheet/controller/angular/example_component_ts.md +++ b/static/usage/v7/action-sheet/controller/angular/example_component_ts.md @@ -1,11 +1,13 @@ ```ts import { Component } from '@angular/core'; +import { IonButton } from '@ionic/angular/standalone'; import { ActionSheetController } from '@ionic/angular'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', + imports: [IonButton], }) export class ExampleComponent { constructor(private actionSheetCtrl: ActionSheetController) {} diff --git a/static/usage/v7/action-sheet/inline/isOpen/angular/example_component_ts.md b/static/usage/v7/action-sheet/inline/isOpen/angular/example_component_ts.md index 78d9ddf05c8..2351fc41d25 100644 --- a/static/usage/v7/action-sheet/inline/isOpen/angular/example_component_ts.md +++ b/static/usage/v7/action-sheet/inline/isOpen/angular/example_component_ts.md @@ -1,9 +1,11 @@ ```ts import { Component } from '@angular/core'; +import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', + imports: [IonActionSheet, IonButton], }) export class ExampleComponent { isActionSheetOpen = false; diff --git a/static/usage/v7/action-sheet/inline/trigger/angular/example_component_ts.md b/static/usage/v7/action-sheet/inline/trigger/angular/example_component_ts.md index f991151c4a1..310c304feca 100644 --- a/static/usage/v7/action-sheet/inline/trigger/angular/example_component_ts.md +++ b/static/usage/v7/action-sheet/inline/trigger/angular/example_component_ts.md @@ -1,9 +1,11 @@ ```ts import { Component } from '@angular/core'; +import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', + imports: [IonActionSheet, IonButton], }) export class ExampleComponent { public actionSheetButtons = [ diff --git a/static/usage/v7/action-sheet/role-info-on-dismiss/angular/example_component_ts.md b/static/usage/v7/action-sheet/role-info-on-dismiss/angular/example_component_ts.md index a38c0b92307..89742a674a8 100644 --- a/static/usage/v7/action-sheet/role-info-on-dismiss/angular/example_component_ts.md +++ b/static/usage/v7/action-sheet/role-info-on-dismiss/angular/example_component_ts.md @@ -1,10 +1,12 @@ ```ts import { Component } from '@angular/core'; +import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', styleUrls: ['./example.component.css'], + imports: [IonActionSheet, IonButton], }) export class ExampleComponent { public actionSheetButtons = [ diff --git a/static/usage/v7/action-sheet/theming/css-properties/angular/example_component_ts.md b/static/usage/v7/action-sheet/theming/css-properties/angular/example_component_ts.md index d9714abb668..709135c1c1f 100644 --- a/static/usage/v7/action-sheet/theming/css-properties/angular/example_component_ts.md +++ b/static/usage/v7/action-sheet/theming/css-properties/angular/example_component_ts.md @@ -1,10 +1,12 @@ ```ts import { Component } from '@angular/core'; +import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', styleUrls: ['./example.component.css'], + imports: [IonActionSheet, IonButton], }) export class ExampleComponent { public actionSheetButtons = [ diff --git a/static/usage/v7/action-sheet/theming/styling/angular/example_component_ts.md b/static/usage/v7/action-sheet/theming/styling/angular/example_component_ts.md index d9714abb668..709135c1c1f 100644 --- a/static/usage/v7/action-sheet/theming/styling/angular/example_component_ts.md +++ b/static/usage/v7/action-sheet/theming/styling/angular/example_component_ts.md @@ -1,10 +1,12 @@ ```ts import { Component } from '@angular/core'; +import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', styleUrls: ['./example.component.css'], + imports: [IonActionSheet, IonButton], }) export class ExampleComponent { public actionSheetButtons = [ diff --git a/static/usage/v8/action-sheet/controller/angular/example_component_ts.md b/static/usage/v8/action-sheet/controller/angular/example_component_ts.md index c7ecc272663..62d15b7039a 100644 --- a/static/usage/v8/action-sheet/controller/angular/example_component_ts.md +++ b/static/usage/v8/action-sheet/controller/angular/example_component_ts.md @@ -1,11 +1,13 @@ ```ts import { Component } from '@angular/core'; +import { IonButton } from '@ionic/angular/standalone'; import { ActionSheetController } from '@ionic/angular'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', + imports: [IonButton], }) export class ExampleComponent { constructor(private actionSheetCtrl: ActionSheetController) {} diff --git a/static/usage/v8/action-sheet/inline/isOpen/angular/example_component_ts.md b/static/usage/v8/action-sheet/inline/isOpen/angular/example_component_ts.md index 78d9ddf05c8..2351fc41d25 100644 --- a/static/usage/v8/action-sheet/inline/isOpen/angular/example_component_ts.md +++ b/static/usage/v8/action-sheet/inline/isOpen/angular/example_component_ts.md @@ -1,9 +1,11 @@ ```ts import { Component } from '@angular/core'; +import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', + imports: [IonActionSheet, IonButton], }) export class ExampleComponent { isActionSheetOpen = false; diff --git a/static/usage/v8/action-sheet/inline/trigger/angular/example_component_ts.md b/static/usage/v8/action-sheet/inline/trigger/angular/example_component_ts.md index f991151c4a1..310c304feca 100644 --- a/static/usage/v8/action-sheet/inline/trigger/angular/example_component_ts.md +++ b/static/usage/v8/action-sheet/inline/trigger/angular/example_component_ts.md @@ -1,9 +1,11 @@ ```ts import { Component } from '@angular/core'; +import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', + imports: [IonActionSheet, IonButton], }) export class ExampleComponent { public actionSheetButtons = [ diff --git a/static/usage/v8/action-sheet/role-info-on-dismiss/angular/example_component_ts.md b/static/usage/v8/action-sheet/role-info-on-dismiss/angular/example_component_ts.md index a38c0b92307..89742a674a8 100644 --- a/static/usage/v8/action-sheet/role-info-on-dismiss/angular/example_component_ts.md +++ b/static/usage/v8/action-sheet/role-info-on-dismiss/angular/example_component_ts.md @@ -1,10 +1,12 @@ ```ts import { Component } from '@angular/core'; +import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', styleUrls: ['./example.component.css'], + imports: [IonActionSheet, IonButton], }) export class ExampleComponent { public actionSheetButtons = [ diff --git a/static/usage/v8/action-sheet/theming/css-properties/angular/example_component_ts.md b/static/usage/v8/action-sheet/theming/css-properties/angular/example_component_ts.md index d9714abb668..709135c1c1f 100644 --- a/static/usage/v8/action-sheet/theming/css-properties/angular/example_component_ts.md +++ b/static/usage/v8/action-sheet/theming/css-properties/angular/example_component_ts.md @@ -1,10 +1,12 @@ ```ts import { Component } from '@angular/core'; +import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', styleUrls: ['./example.component.css'], + imports: [IonActionSheet, IonButton], }) export class ExampleComponent { public actionSheetButtons = [ diff --git a/static/usage/v8/action-sheet/theming/styling/angular/example_component_ts.md b/static/usage/v8/action-sheet/theming/styling/angular/example_component_ts.md index d9714abb668..709135c1c1f 100644 --- a/static/usage/v8/action-sheet/theming/styling/angular/example_component_ts.md +++ b/static/usage/v8/action-sheet/theming/styling/angular/example_component_ts.md @@ -1,10 +1,12 @@ ```ts import { Component } from '@angular/core'; +import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', styleUrls: ['./example.component.css'], + imports: [IonActionSheet, IonButton], }) export class ExampleComponent { public actionSheetButtons = [ From a85c73d8d9b92948317d33692b9296857154968a Mon Sep 17 00:00:00 2001 From: Brandy Carney <6577830+brandyscarney@users.noreply.github.com> Date: Thu, 19 Dec 2024 17:05:39 -0500 Subject: [PATCH 2/5] docs(action-sheet): fix type errors --- .../role-info-on-dismiss/angular/example_component_ts.md | 4 +++- .../role-info-on-dismiss/angular/example_component_ts.md | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/static/usage/v7/action-sheet/role-info-on-dismiss/angular/example_component_ts.md b/static/usage/v7/action-sheet/role-info-on-dismiss/angular/example_component_ts.md index 89742a674a8..12911d283c3 100644 --- a/static/usage/v7/action-sheet/role-info-on-dismiss/angular/example_component_ts.md +++ b/static/usage/v7/action-sheet/role-info-on-dismiss/angular/example_component_ts.md @@ -1,6 +1,7 @@ ```ts import { Component } from '@angular/core'; import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; +import type { OverlayEventDetail } from '@ionic/core'; @Component({ selector: 'app-example', @@ -34,7 +35,8 @@ export class ExampleComponent { constructor() {} - logResult(ev) { + logResult(event: Event) { + const ev = event as CustomEvent>; console.log(JSON.stringify(ev.detail, null, 2)); } } diff --git a/static/usage/v8/action-sheet/role-info-on-dismiss/angular/example_component_ts.md b/static/usage/v8/action-sheet/role-info-on-dismiss/angular/example_component_ts.md index 89742a674a8..12911d283c3 100644 --- a/static/usage/v8/action-sheet/role-info-on-dismiss/angular/example_component_ts.md +++ b/static/usage/v8/action-sheet/role-info-on-dismiss/angular/example_component_ts.md @@ -1,6 +1,7 @@ ```ts import { Component } from '@angular/core'; import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; +import type { OverlayEventDetail } from '@ionic/core'; @Component({ selector: 'app-example', @@ -34,7 +35,8 @@ export class ExampleComponent { constructor() {} - logResult(ev) { + logResult(event: Event) { + const ev = event as CustomEvent>; console.log(JSON.stringify(ev.detail, null, 2)); } } From b77991f8ffecb5f24e5a2a66f2f1f45d2e1be95b Mon Sep 17 00:00:00 2001 From: Brandy Carney <6577830+brandyscarney@users.noreply.github.com> Date: Fri, 20 Dec 2024 14:57:34 -0500 Subject: [PATCH 3/5] docs(action-sheet): update angular to standalone --- .../v7/action-sheet/controller/angular/example_component_ts.md | 1 + .../action-sheet/inline/isOpen/angular/example_component_ts.md | 1 + .../action-sheet/inline/trigger/angular/example_component_ts.md | 1 + .../v8/action-sheet/controller/angular/example_component_ts.md | 1 + .../action-sheet/inline/isOpen/angular/example_component_ts.md | 1 + .../action-sheet/inline/trigger/angular/example_component_ts.md | 1 + 6 files changed, 6 insertions(+) diff --git a/static/usage/v7/action-sheet/controller/angular/example_component_ts.md b/static/usage/v7/action-sheet/controller/angular/example_component_ts.md index 62d15b7039a..93634bd5397 100644 --- a/static/usage/v7/action-sheet/controller/angular/example_component_ts.md +++ b/static/usage/v7/action-sheet/controller/angular/example_component_ts.md @@ -7,6 +7,7 @@ import { ActionSheetController } from '@ionic/angular'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', + styleUrls: ['example.component.css'], imports: [IonButton], }) export class ExampleComponent { diff --git a/static/usage/v7/action-sheet/inline/isOpen/angular/example_component_ts.md b/static/usage/v7/action-sheet/inline/isOpen/angular/example_component_ts.md index 2351fc41d25..df6c89aabe0 100644 --- a/static/usage/v7/action-sheet/inline/isOpen/angular/example_component_ts.md +++ b/static/usage/v7/action-sheet/inline/isOpen/angular/example_component_ts.md @@ -5,6 +5,7 @@ import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', + styleUrls: ['example.component.css'], imports: [IonActionSheet, IonButton], }) export class ExampleComponent { diff --git a/static/usage/v7/action-sheet/inline/trigger/angular/example_component_ts.md b/static/usage/v7/action-sheet/inline/trigger/angular/example_component_ts.md index 310c304feca..082f779fe19 100644 --- a/static/usage/v7/action-sheet/inline/trigger/angular/example_component_ts.md +++ b/static/usage/v7/action-sheet/inline/trigger/angular/example_component_ts.md @@ -5,6 +5,7 @@ import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', + styleUrls: ['example.component.css'], imports: [IonActionSheet, IonButton], }) export class ExampleComponent { diff --git a/static/usage/v8/action-sheet/controller/angular/example_component_ts.md b/static/usage/v8/action-sheet/controller/angular/example_component_ts.md index 62d15b7039a..93634bd5397 100644 --- a/static/usage/v8/action-sheet/controller/angular/example_component_ts.md +++ b/static/usage/v8/action-sheet/controller/angular/example_component_ts.md @@ -7,6 +7,7 @@ import { ActionSheetController } from '@ionic/angular'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', + styleUrls: ['example.component.css'], imports: [IonButton], }) export class ExampleComponent { diff --git a/static/usage/v8/action-sheet/inline/isOpen/angular/example_component_ts.md b/static/usage/v8/action-sheet/inline/isOpen/angular/example_component_ts.md index 2351fc41d25..df6c89aabe0 100644 --- a/static/usage/v8/action-sheet/inline/isOpen/angular/example_component_ts.md +++ b/static/usage/v8/action-sheet/inline/isOpen/angular/example_component_ts.md @@ -5,6 +5,7 @@ import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', + styleUrls: ['example.component.css'], imports: [IonActionSheet, IonButton], }) export class ExampleComponent { diff --git a/static/usage/v8/action-sheet/inline/trigger/angular/example_component_ts.md b/static/usage/v8/action-sheet/inline/trigger/angular/example_component_ts.md index 310c304feca..082f779fe19 100644 --- a/static/usage/v8/action-sheet/inline/trigger/angular/example_component_ts.md +++ b/static/usage/v8/action-sheet/inline/trigger/angular/example_component_ts.md @@ -5,6 +5,7 @@ import { IonActionSheet, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', templateUrl: 'example.component.html', + styleUrls: ['example.component.css'], imports: [IonActionSheet, IonButton], }) export class ExampleComponent { From 1f550aae49c16357cce89f7bef98f2c9cbca06ad Mon Sep 17 00:00:00 2001 From: Brandy Carney <6577830+brandyscarney@users.noreply.github.com> Date: Fri, 27 Dec 2024 15:36:35 -0500 Subject: [PATCH 4/5] docs(action-sheet): update angular to standalone --- .../action-sheet/controller/angular/example_component_ts.md | 4 +--- .../action-sheet/controller/angular/example_component_ts.md | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/static/usage/v7/action-sheet/controller/angular/example_component_ts.md b/static/usage/v7/action-sheet/controller/angular/example_component_ts.md index 93634bd5397..7257bcb45e6 100644 --- a/static/usage/v7/action-sheet/controller/angular/example_component_ts.md +++ b/static/usage/v7/action-sheet/controller/angular/example_component_ts.md @@ -1,8 +1,6 @@ ```ts import { Component } from '@angular/core'; -import { IonButton } from '@ionic/angular/standalone'; - -import { ActionSheetController } from '@ionic/angular'; +import { ActionSheetController, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', diff --git a/static/usage/v8/action-sheet/controller/angular/example_component_ts.md b/static/usage/v8/action-sheet/controller/angular/example_component_ts.md index 93634bd5397..7257bcb45e6 100644 --- a/static/usage/v8/action-sheet/controller/angular/example_component_ts.md +++ b/static/usage/v8/action-sheet/controller/angular/example_component_ts.md @@ -1,8 +1,6 @@ ```ts import { Component } from '@angular/core'; -import { IonButton } from '@ionic/angular/standalone'; - -import { ActionSheetController } from '@ionic/angular'; +import { ActionSheetController, IonButton } from '@ionic/angular/standalone'; @Component({ selector: 'app-example', From 03c040ad3a379afefff3b261457b72f4da898a1a Mon Sep 17 00:00:00 2001 From: Brandy Carney <6577830+brandyscarney@users.noreply.github.com> Date: Mon, 30 Dec 2024 14:16:23 -0500 Subject: [PATCH 5/5] docs(action-sheet): type changes --- .../role-info-on-dismiss/angular/example_component_ts.md | 5 ++--- .../role-info-on-dismiss/angular/example_component_ts.md | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/static/usage/v7/action-sheet/role-info-on-dismiss/angular/example_component_ts.md b/static/usage/v7/action-sheet/role-info-on-dismiss/angular/example_component_ts.md index 12911d283c3..f0f7fcc8d50 100644 --- a/static/usage/v7/action-sheet/role-info-on-dismiss/angular/example_component_ts.md +++ b/static/usage/v7/action-sheet/role-info-on-dismiss/angular/example_component_ts.md @@ -35,9 +35,8 @@ export class ExampleComponent { constructor() {} - logResult(event: Event) { - const ev = event as CustomEvent>; - console.log(JSON.stringify(ev.detail, null, 2)); + logResult(event: CustomEvent>) { + console.log(JSON.stringify(event.detail, null, 2)); } } ``` diff --git a/static/usage/v8/action-sheet/role-info-on-dismiss/angular/example_component_ts.md b/static/usage/v8/action-sheet/role-info-on-dismiss/angular/example_component_ts.md index 12911d283c3..f0f7fcc8d50 100644 --- a/static/usage/v8/action-sheet/role-info-on-dismiss/angular/example_component_ts.md +++ b/static/usage/v8/action-sheet/role-info-on-dismiss/angular/example_component_ts.md @@ -35,9 +35,8 @@ export class ExampleComponent { constructor() {} - logResult(event: Event) { - const ev = event as CustomEvent>; - console.log(JSON.stringify(ev.detail, null, 2)); + logResult(event: CustomEvent>) { + console.log(JSON.stringify(event.detail, null, 2)); } } ```