Skip to content

Commit 6f3f125

Browse files
liamdebeasiIonitron
andcommitted
fix(textarea): legacy textarea respects padding (#27219)
Issue URL: resolves #27218 --------- <!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Padding is not applied to the `.native-textarea` element when using a legacy textarea. It is applied in v6: https://github.com/ionic-team/ionic-framework/blob/ae9689bf3e185749dd2e0b27864b1c99b129820e/core/src/components/textarea/textarea.scss#L98-L100 The modern textarea is not impacted. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Padding is now added to `.native-textarea` with the legacy textarea. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <[email protected]>
1 parent e4da7fc commit 6f3f125

File tree

109 files changed

+1
-0
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

109 files changed

+1
-0
lines changed

core/src/components/textarea/textarea.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@
160160
}
161161

162162
// TODO: FW-2876 - Remove this selector
163+
:host(.legacy-textarea) .native-textarea,
163164
:host(.legacy-textarea) .textarea-legacy-wrapper::after {
164165
@include padding(var(--padding-top), var(--padding-end), var(--padding-bottom), var(--padding-start));
165166
@include border-radius(var(--border-radius));

0 commit comments

Comments
 (0)