Skip to content

Commit d3232dc

Browse files
authored
chore(global): remove unused context references (#27634)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Ionic Framework references a deprecated object,`Context`, exposed by Stencil ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> starting with stencil v4, the deprecated `Context` object will no longer be exposed by stencil. this change was introduced in stenciljs/core#4437, and will be present in the first v4 prerelease following v4.0.0-beta.2. in anticipation for this change, we seek to remove references to `Context` early. ## Does this introduce a breaking change? - [ ] Yes - [x] No - To the best of my knowledge <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information ATM, the Stencil v4 nightly build is passing, as it's grabbing `@stencil/[email protected]`. The change in which we remove the `Context` object will occur in the _next_ pre-release. I'm removing `Context` here to try to get a jump on things. The current iteration of the code that I'm deleting was added in c415bbe#diff-ce62e75f0c31a76aac491f13a64e9c7771a6cbae8ca6635541164b69f0479bf1 <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
1 parent fe39a2a commit d3232dc

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

core/src/global/ionic-global.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import { config, configFromSession, configFromURL, saveConfig } from './config';
77

88
// TODO(FW-2832): types
99

10-
declare const Context: any;
11-
1210
let defaultMode: Mode;
1311

1412
export const getIonMode = (ref?: any): Mode => {
@@ -22,7 +20,6 @@ export const initialize = (userConfig: IonicConfig = {}) => {
2220

2321
const doc = window.document;
2422
const win = window;
25-
Context.config = config;
2623
const Ionic = ((win as any).Ionic = (win as any).Ionic || {});
2724

2825
const platformHelpers: any = {};

0 commit comments

Comments
 (0)