Skip to content

Commit efabfdd

Browse files
committed
note limitation
1 parent 4b2710d commit efabfdd

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

core/src/utils/input-shims/hacks/scroll-assist.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,14 @@ export const enableScrollAssist = (
115115
* webview is fullsize) then it's possible that the webview has resized.
116116
* In that case we add the keyboard height to get the real platform height (the
117117
* height when the keyboard is closed).
118+
*
119+
* Note: If the device rotates while the keyboard is open,
120+
* this callback should fire again. However, the initialPlatformHeight
121+
* will be wrong, and the input may scroll more than it needs to (though it
122+
* will always remain in view).
123+
* In order to address this, we need to be able to determine the platform
124+
* height without the keyboard which we are unable to do because we don't
125+
* know if the webview has resized yet.
118126
*/
119127
if (
120128
keyboardResize !== undefined &&

0 commit comments

Comments
 (0)