diff --git a/BREAKING.md b/BREAKING.md index 08b750a227c..10fc6c9f5f1 100644 --- a/BREAKING.md +++ b/BREAKING.md @@ -19,6 +19,8 @@ This is a comprehensive list of the breaking changes introduced in the major ver * [Toolbar](#toolbar) - [Config](#config) * [Transition Shadow](#transition-shadow) +- [Angular](#angular) + * [Config Provider](#config-provider) @@ -64,6 +66,14 @@ var(--ion-toolbar-background, var(--ion-color-step-50, #f7f7f7)); The `experimentalTransitionShadow` config option has been removed. The transition shadow is now enabled when running in `ios` mode. +### Angular + +#### Config Provider + +The `Config.set()` method has been removed. See https://ionicframework.com/docs/angular/config for examples on how to set config globally, per-component, and per-platform. + + + ## Version 5.x diff --git a/angular/src/providers/config.ts b/angular/src/providers/config.ts index c51c0a6c40e..7f1fce63bbf 100644 --- a/angular/src/providers/config.ts +++ b/angular/src/providers/config.ts @@ -31,14 +31,6 @@ export class Config { } return 0; } - - set(key: keyof IonicConfig, value?: any) { - console.warn(`[DEPRECATION][Config]: The Config.set() method is deprecated and will be removed in Ionic Framework 6.0. Please see https://ionicframework.com/docs/angular/config for alternatives.`); - const c = getConfig(); - if (c) { - c.set(key, value); - } - } } export const ConfigToken = new InjectionToken('USERCONFIG'); diff --git a/angular/test/test-app/src/app/app.module.ts b/angular/test/test-app/src/app/app.module.ts index 675292b6b81..8c7ad1d2c72 100644 --- a/angular/test/test-app/src/app/app.module.ts +++ b/angular/test/test-app/src/app/app.module.ts @@ -63,7 +63,7 @@ import { AlertComponent } from './alert/alert.component'; AppRoutingModule, FormsModule, ReactiveFormsModule, - IonicModule.forRoot(), + IonicModule.forRoot({ keyboardHeight: 12345 }), ], entryComponents: [ ModalExampleComponent, diff --git a/angular/test/test-app/src/app/providers/providers.component.ts b/angular/test/test-app/src/app/providers/providers.component.ts index 7e6436d7ded..a928b13a7cc 100644 --- a/angular/test/test-app/src/app/providers/providers.component.ts +++ b/angular/test/test-app/src/app/providers/providers.component.ts @@ -69,7 +69,6 @@ export class ProvidersComponent { // test config this.isTesting = config.getBoolean('_testing'); - config.set('keyboardHeight', 12345); this.keyboardHeight = config.getNumber('keyboardHeight'); zone.runOutsideAngular(() => {