[Vue] Make inputs functional components #19087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionitron-bot
bot
added
package: core
michaeltintiuc
changed the title
|
Thanks for the PR! This is resolved in Ionic Vue for Vue 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Performance improvement, bug fixes, partial documentation update
Please check the type of change your PR introduces:
What is the current behavior?
Currently the Vue wrappers for Ionic inputs are basic components, thus they have state and instances which impact performance. Also several events were missing thus some of the components didn't function properly.
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
Changes were tested with all of the Ionic input components, their respective events and properties.
v-model was tested separately on each component as well as using the same property to manipulate multiple components, for instance ion-input's value to drive ion-radio value through the same data property.
I've updated the usage docs for IonInput but not for the rest of the components as I wasn't quite sure on your guidelines for these wrappers in cases where v-model or event listeners were not required, let me know and I'll be happy to update the rest.