Remove duplicate math transpilation function (ROCm#233)

* Remove duplicate math transpilation function

* Modify regex to expand matches to more __device__ functions

* Try a different tack. Apply math transpilations only to .cu and .cuh files

* Undo change that's not required anymore since we're not using regex to detect device functions

Author: jithunnair-amd

tools/amd_build/pyHIPIFY/hipify-python.py

@@ -506,9 +506,9 @@ def replace_math_functions(input_string):
         Plan is to remove this function once HIP supports std:: math function calls inside device code
     """
     output_string = input_string
-    output_string = re.sub("std::exp\(", "::exp(", output_string)
-    output_string = re.sub("std::log\(", "::log(", output_string)
-    output_string = re.sub("std::pow\(", "::pow(", output_string)
+    for func in MATH_TRANSPILATIONS:
+      output_string = output_string.replace(r'{}('.format(func), '{}('.format(MATH_TRANSPILATIONS[func]))
+
     return output_string
 
 
@@ -763,10 +763,8 @@ def preprocessor(filepath, stats, hipify_caffe2):
         #    output_source = disable_asserts(output_source)
 
         # Replace std:: with non-std:: versions
-        output_source = replace_math_functions(output_source)
-
-        # Replace std:: with non-std:: versions
-        output_source = transpile_device_math(output_source)
+        if re.search(r"\.cu$", filepath) or re.search(r"\.cuh$", filepath):
+          output_source = replace_math_functions(output_source)
 
         # Replace __forceinline__ with inline
         output_source = replace_forceinline(output_source)
@@ -947,31 +945,6 @@ def disable_module(input_file):
         f.truncate()
 
 
-def transpile_device_math(input_string):
-    """ Temporarily replace std:: invocations of math functions with non-std:: versions."""
-    # Extract device code positions
-    get_kernel_definitions = [k for k in re.finditer( r"(template[ ]*<(.*)>\n.*\n?)?(__global__|__device__) void[\n| ](\w+(\(.*\))?)\(", input_string)]
-
-    # Prepare output
-    output_string = input_string
-
-    # Iterate through each kernel definition
-    for kernel in get_kernel_definitions:
-        # Find the final paranthesis that closes this kernel function definition.
-        _, paranth_end = find_bracket_group(input_string, kernel.end() - 1)
-
-        # Replace all std:: math functions within range [start...ending]
-        selection = input_string[kernel.start():paranth_end + 1]
-        selection_transpiled = selection
-        for func in MATH_TRANSPILATIONS:
-            selection_transpiled = selection_transpiled.replace(func, MATH_TRANSPILATIONS[func])
-
-        # Perform replacements inside the output_string
-        output_string = output_string.replace(selection, selection_transpiled)
-
-    return output_string
-
-
 def extract_arguments(start, string):
     """ Return the list of arguments in the upcoming function parameter closure.
         Example: